Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Blank Mod Options Menu #271

Closed
Classic1969 opened this issue Apr 5, 2019 · 12 comments · Fixed by #290
Closed

Blank Mod Options Menu #271

Classic1969 opened this issue Apr 5, 2019 · 12 comments · Fixed by #290
Labels
BUG Defect detected COMPATIBILITY Mod (in)compatibility / checker confirmed Represents confirmed issue or bug EXTERNAL Mod conflict or other external factor Settings Road config, mod options, config xml
Milestone

Comments

@Classic1969
Copy link

Classic1969 commented Apr 5, 2019

Solution

This issue is caused by the "Vanilla Tree Remover" mod. Disable or unsubscribe that mod.

The mod author is aware of the issue.


When I navigate to the mod's mod options menu while in a save-game, it appears completely blank. When I do so in the main menu before entering a save-game, the menu appears just fine (albeit some text is squished together but this is a known issue).

Output log:
output_log.txt

55650201-fd8feb80-57dc-11e9-8528-0210151036ef

@originalfoo
Copy link
Member

Thanks for the log file

Tagging #250

@originalfoo
Copy link
Member

originalfoo commented Apr 5, 2019

Some UI errors - not sure if these are TMPE or something else though...

IndexOutOfRangeException: Array index is out of range.
  at ColossalFramework.PoolList`1[ColossalFramework.UI.UIComponent].get_Item (Int32 index) [0x00000] in <filename unknown>:0 
  at ColossalFramework.UI.UITabContainer.SelectPageByIndex (Int32 value) [0x00000] in <filename unknown>:0 
  at ColossalFramework.UI.UITabContainer.set_selectedIndex (Int32 value) [0x00000] in <filename unknown>:0 
  at OptionsMainPanel.SetContainerCategory (Int32 index) [0x00000] in <filename unknown>:0 
  at OptionsMainPanel.OnCategoryChanged (ColossalFramework.UI.UIComponent c, Int32 index) [0x00000] in <filename unknown>:0 
  at ColossalFramework.UI.UIListBox.OnSelectedIndexChanged () [0x00000] in <filename unknown>:0 
  at ColossalFramework.UI.UIListBox.set_selectedIndex (Int32 value) [0x00000] in <filename unknown>:0 
  at ColossalFramework.UI.UIListBox.OnMouseDown (ColossalFramework.UI.UIMouseEventParameter p) [0x00000] in <filename unknown>:0 
  at ColossalFramework.UI.UIInput+MouseHandler.ProcessInput (IInputTranslator translator, Ray ray, ColossalFramework.UI.UIComponent component, Boolean retainFocusSetting) [0x00000] in <filename unknown>:0 
  at ColossalFramework.UI.UIInput.ProcessMouseInput () [0x00000] in <filename unknown>:0 
  at ColossalFramework.UI.UIInput.Update () [0x00000] in <filename unknown>:0 

There's about 5 or 6 of those.

@originalfoo
Copy link
Member

@krzychu124 Does this look like the same issue as #250 fixes?

@originalfoo originalfoo added BUG Defect detected confirmed Represents confirmed issue or bug investigating Issue currently under investigation labels Apr 5, 2019
@krzychu124
Copy link
Member

krzychu124 commented Apr 6, 2019

@aubergine10 I don't think so, but would be great to know if it happen only on that savegame or in general after loading any
@Classic1969 could you share your savegame?

@jakeroot1
Copy link

I've had an issue where one of my other mods' menus wouldn't load, and it would cause the mod options to shift up by one. So, in your case (looking at your screenshot on Steam), I would have had to select "Move It!" to access "TM:PE", "Roundabout Builder" to access "Move it!", and so on.

@1Tomber
Copy link

1Tomber commented Apr 8, 2019

I already mentioned it in #250 - My TM:PE settings disappear after changing the language in-game. Restarting brings it back. Changing it in the main menu is fine. Maybe the bug is associated?
After changing the language output_log.txt shows:

NullReferenceException
at (wrapper managed-to-native) UnityEngine.Component.get_gameObject () <0x00075>
at (wrapper dynamic-method) OptionsMainPanel.CreateCategories_Patch1 (object) <0x00154>
at OptionsMainPanel.OnLocaleChanged () <0x0001c>
at (wrapper managed-to-native) System.Reflection.MonoMethod.InternalInvoke (object,object[],System.Exception&) <0x00080>
at System.Reflection.MonoMethod.Invoke (object,System.Reflection.BindingFlags,System.Reflection.Binder,object[],System.Globalization.CultureInfo) <0x001ac>

Rethrow as TargetInvocationException: Exception has been thrown by the target of an invocation.
  at System.Reflection.MonoMethod.Invoke (System.Object obj, BindingFlags invokeAttr, System.Reflection.Binder binder, System.Object[] parameters, System.Globalization.CultureInfo culture) [0x00000] in <filename unknown>:0 
  at System.Reflection.MethodBase.Invoke (System.Object obj, System.Object[] parameters) [0x00000] in <filename unknown>:0 
  at TrafficManager.State.Options.onLanguageChanged (Int32 newLanguageIndex) [0x00000] in <filename unknown>:0 
  at UIHelper+<AddDropdown>c__AnonStorey2.<>m__0 (ColossalFramework.UI.UIComponent c, Int32 sel) [0x00000] in <filename unknown>:0 
  at ColossalFramework.UI.UIDropDown.OnSelectedIndexChanged () [0x00000] in <filename unknown>:0 
  at ColossalFramework.UI.UIDropDown.set_selectedIndex (Int32 value) [0x00000] in <filename unknown>:0 
  at ColossalFramework.UI.UIDropDown.PopupSelectedIndexChanged (ColossalFramework.UI.UIComponent component, Int32 si) [0x00000] in <filename unknown>:0 
  at ColossalFramework.UI.UIListBox.OnSelectedIndexChanged () [0x00000] in <filename unknown>:0 
  at ColossalFramework.UI.UIListBox.set_selectedIndex (Int32 value) [0x00000] in <filename unknown>:0 
  at ColossalFramework.UI.UIListBox.OnMouseDown (ColossalFramework.UI.UIMouseEventParameter p) [0x00000] in <filename unknown>:0 
  at ColossalFramework.UI.UIInput+MouseHandler.ProcessInput (IInputTranslator translator, Ray ray, ColossalFramework.UI.UIComponent component, Boolean retainFocusSetting) [0x00000] in <filename unknown>:0 
  at ColossalFramework.UI.UIInput.ProcessMouseInput () [0x00000] in <filename unknown>:0 
  at ColossalFramework.UI.UIInput.Update () [0x00000] in <filename unknown>:0 
 
(Filename:  Line: -1)

@krzychu124
Copy link
Member

krzychu124 commented Apr 8, 2019

OptionsMainPanel.CreateCategories_Patch1... looks like other mod patched original options menu using Harmony. TMPE only triggers original event to reload whole menu. In this case process failed and TMPE options were destroyed but not recreated 😕

@originalfoo
Copy link
Member

Do you have mods made by pcfantasy installed (Advanced Junction Rule, that sort of thing)?

@1Tomber
Copy link

1Tomber commented Apr 9, 2019

Took some time, but I found "Vanilla Trees Remover" from TPB responsible for the problem I described: https://steamcommunity.com/sharedfiles/filedetails/?id=877950833
It is also responsible for a bug, where "vanilla rees remover" mods settings are not available in-game and all settings shift by one position in the list - but this doesn't happen if you use the "Sort Mod Settings" mod...
@Classic1969 you also have that mod installed, can you try to disable the Vanilla Trees Remover" mod?

@originalfoo
Copy link
Member

originalfoo commented Apr 9, 2019

Seems like other users also have similar problems with the tree remover mod, some recent examples from the mods' workshop page:

Sakuro 28 Jan @ 4:43pm
Hi TPB, I like your mod and I think it is a very important and useful mod because of the Network Skin performance issue. I just wanted to tell you that I found a bug on the mod list into the options panel. Indeed, there is a kind of lag when you select your mod then another one just after it...Don't know if someone mention it before me but...

CreativeFraser 30 Jan @ 7:42am
Can second Sakuro's experience; if I try to view options for this mod while in-game, there will be none listed and instead the options for the mod next in the load order will be shown. Options working fine from main menu though. Might be issue on my end though.

I've pinged TPB on the dev chat to let him know.

In interim I suggest unsubbing the mod as it seems to be causing at least 3 separate issues:

  1. Content manager > Mods: blank screen (fixable with F5 key, or 'Sorted Mod List' mod)
  2. Content manager > Mods > Options button: Sometimes shows options for previous or subsequent mod (can be fixed with 'Sorted Mod List' mod)
  3. Content manager > Mods > Options screen: Sometimes blank

Note that 3rd item above could potentially be exacerbated by TM:PE bug in #250.

@originalfoo originalfoo added EXTERNAL Mod conflict or other external factor and removed investigating Issue currently under investigation labels Apr 9, 2019
@Classic1969
Copy link
Author

I can confirm on my end, removing the tree remover mod allowed me to access the TM:PE options menu in-game.

@originalfoo
Copy link
Member

Added a troubleshooting guide.

Closing issue.

originalfoo added a commit that referenced this issue Apr 20, 2019
Fixes #271

Vanilla Trees Remover added to incompatible mods list. It causes issues with mod options for TM:PE and other mods. Symptoms are either: Completely blank mods screen, or options from a different mod are shown. TPB is aware of the issue.
@originalfoo originalfoo added this to the 10.19 milestone Apr 20, 2019
@originalfoo originalfoo added Settings Road config, mod options, config xml COMPATIBILITY Mod (in)compatibility / checker labels Aug 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BUG Defect detected COMPATIBILITY Mod (in)compatibility / checker confirmed Represents confirmed issue or bug EXTERNAL Mod conflict or other external factor Settings Road config, mod options, config xml
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants