Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mod checker should ignore blank lines in incompatible_mods.txt #441

Closed
originalfoo opened this issue Jul 19, 2019 · 0 comments · Fixed by #443
Closed

Mod checker should ignore blank lines in incompatible_mods.txt #441

originalfoo opened this issue Jul 19, 2019 · 0 comments · Fixed by #443
Assignees
@originalfoo
Labels
COMPATIBILITY Mod (in)compatibility / checker enhancement Improve existing feature in-progress The problem is being solved currently technical Tasks that need to be performed in order to improve quality and maintainability
Milestone
11.0

Comments

@originalfoo
Copy link
Member

Currently it throws an error.
@originalfoo originalfoo added enhancement Improve existing feature technical Tasks that need to be performed in order to improve quality and maintainability labels Jul 19, 2019
@originalfoo originalfoo added this to the 11.0 milestone Jul 19, 2019
@originalfoo originalfoo self-assigned this Jul 19, 2019
@originalfoo originalfoo added the in-progress The problem is being solved currently label Jul 19, 2019
originalfoo added a commit that referenced this issue Jul 21, 2019
@originalfoo
Ignore blank lines in incompatible_mods.txt
8247b79 
Skips blank lines rather than throwing an error

Fixes #441
@originalfoo originalfoo mentioned this issue Jul 21, 2019
Merged
@originalfoo originalfoo added the COMPATIBILITY Mod (in)compatibility / checker label Aug 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@originalfoo originalfoo

Labels
COMPATIBILITY Mod (in)compatibility / checker enhancement Improve existing feature in-progress The problem is being solved currently technical Tasks that need to be performed in order to improve quality and maintainability
Projects
None yet
Milestone
11.0
Development

Successfully merging a pull request may close this issue.

Various mod checker tweaks CitiesSkylinesMods/TMPE
1 participant
@originalfoo