Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conflict with Klyte45's Trees Respiration Mod #484

Closed
TroublesomeCorvid opened this issue Aug 13, 2019 · 5 comments
Closed

Conflict with Klyte45's Trees Respiration Mod #484

TroublesomeCorvid opened this issue Aug 13, 2019 · 5 comments
Labels
BUG Defect detected COMPATIBILITY Mod (in)compatibility / checker confirmed Represents confirmed issue or bug EXTERNAL Mod conflict or other external factor LABS TM:PE LABS branch STABLE TM:PE STABLE branch
Milestone

Comments

@TroublesomeCorvid
Copy link

Description

Whenever TP:ME and Trees Respiration are active at the same time I get an error from TP:ME about a mod conflict.

I've already left a message to Klyte45 on the workshop page of his mod, but this is my first time doing this - I don't know if he's going to get in touch with you or not.

Reproduction Steps

Add more steps as necessary.

  1. Have TP:ME and Trees Respiration active
  2. Start a new city

Mod List

Please list the mods enabled when you noticed the bug.

I started a new city in vanilla mode save for Trees Respiration and TP:ME being the only active mods. I still got an error message, so I'm pretty sure that there aren't any other mods messing with this. To make doubly sure, I replaced what mods I could with the ones in your reccomended mods list. Still no love.

Output Log

output_log.txt

Savegame (Optional)

Screenshots (Optional)

Additional Info

@TroublesomeCorvid TroublesomeCorvid added BUG Defect detected triage Awaiting issue categorisation labels Aug 13, 2019
@krzychu124
Copy link
Member

Hi, the problem is that both Stable and Labs versions of TM:PE are using different method redirection. Trees Respiration mod is connecting it's methods to original call chain but our redirector overwrite that original method so it sometimes works, sometimes not, depends on which mod is loaded first(random).

Our latest alpha build is rewritten to use the same approach for redirecting methods as used in Trees Respiration and many other mods.
Both mods should work without issues on alpha build.

If you want to became a tester, here is the link.
TM:PE v11-alpha6

Please read and follow instructions in description.

@TroublesomeCorvid
Copy link
Author

Thanks much. I'll give it a shot later on in the next day or two here.

@originalfoo originalfoo added confirmed Represents confirmed issue or bug EXTERNAL Mod conflict or other external factor and removed triage Awaiting issue categorisation labels Aug 13, 2019
@originalfoo originalfoo added this to the 11.0 milestone Aug 13, 2019
@originalfoo originalfoo added COMPATIBILITY Mod (in)compatibility / checker LABS TM:PE LABS branch STABLE TM:PE STABLE branch labels Aug 13, 2019
@nonchip
Copy link

nonchip commented Apr 11, 2020

i've got the labs version, and it still warns me not to use the respiration mod. but there doesn't seem to be an issue running both at once. is that just because the 2 versions share the same list of incompatible mods?

@originalfoo
Copy link
Member

They are now compatible thanks to update by @klyte45, I'm just about to update the compatibility list to stop the warning.

@nonchip
Copy link

nonchip commented Apr 11, 2020

thanks just wanted to double check with you :)

originalfoo added a commit that referenced this issue Apr 11, 2020
The mod is now compatible thanks to update from @klyte45

Tagging:  #614, #611, #563, #484
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BUG Defect detected COMPATIBILITY Mod (in)compatibility / checker confirmed Represents confirmed issue or bug EXTERNAL Mod conflict or other external factor LABS TM:PE LABS branch STABLE TM:PE STABLE branch
Projects
None yet
Development

No branches or pull requests

4 participants