Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue with mulirow tooltip translation strings #574

Closed
krzychu124 opened this issue Nov 27, 2019 · 1 comment · Fixed by #589
Closed

Issue with mulirow tooltip translation strings #574

krzychu124 opened this issue Nov 27, 2019 · 1 comment · Fixed by #589
Assignees
Labels
BUG Defect detected Localisation Localised text and features
Milestone

Comments

@krzychu124
Copy link
Member

I've noticed an issue while working with #572.

If translator add invisible line break instead of \n Crowdin generates multiple rows for singe translation string.The rest of translation after line break is not properly loaded in-game.

I suggest split multirow tooltips and separate key modifier (combination Ctrl/Shift/Alt with click) translation from tooltip text because it confuses translators.

@krzychu124 krzychu124 added the Localisation Localised text and features label Nov 27, 2019
@krzychu124 krzychu124 added this to the 11.0 milestone Nov 27, 2019
@kvakvs
Copy link
Collaborator

kvakvs commented Nov 27, 2019

I suggest the plan

  1. Check if that is valid CSV (quick google search says that yes, it is)
  2. If that is, fix CSV loading code to consume newline if a quotation mark is open.

@originalfoo originalfoo added the BUG Defect detected label Nov 29, 2019
@krzychu124 krzychu124 self-assigned this Dec 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BUG Defect detected Localisation Localised text and features
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants