Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Turkish and Ukrainian language support #572

Merged
merged 3 commits into from
Nov 27, 2019
Merged

Turkish and Ukrainian language support #572

merged 3 commits into from
Nov 27, 2019

Conversation

krzychu124
Copy link
Member

@krzychu124 krzychu124 commented Nov 26, 2019

Added Turkish and Ukrainian language support.

  • tr : ISO 639-1 Turkish language id (Tayfun[Typhoon] (Koop on Steam)),
  • uk : ISO 639-1 Ukrainian language id (kvakvs),
  • updated translations,
  • included new Auto Traffic Lights (default Timed traffic light #554 ) translation keys

@krzychu124 krzychu124 added the Localisation Localised text and features label Nov 26, 2019
@krzychu124 krzychu124 added this to the 11.0 milestone Nov 26, 2019
@krzychu124 krzychu124 self-assigned this Nov 26, 2019
Copy link
Member

@originalfoo originalfoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Contributor list for changelog?

@krzychu124
Copy link
Member Author

Tayfun[Typhoon] (Koop on Steam, I think) I will add one more commit later today, because I see that he added more translations

@krzychu124 krzychu124 added the DO NOT MERGE YET Don't merge this PR, even if approved, until further notice label Nov 27, 2019
@krzychu124 krzychu124 changed the title Turkish language support Turkish and Ukrainian language support Nov 27, 2019
@krzychu124 krzychu124 removed the DO NOT MERGE YET Don't merge this PR, even if approved, until further notice label Nov 27, 2019
@kvakvs
Copy link
Collaborator

kvakvs commented Nov 27, 2019

krzychu124: Assigning multirow text to single string wasn't the best idea. @kvakvs🚦 you've added invisible line break in Tooltip.Keybinds:Change lane arrows which breaks generated translation row to two lines, Alt+Клік tooltip text is not visible in game :/
bild

@originalfoo
Copy link
Member

On a cursory glance, line break issue is fixed. LGTM 👍

@krzychu124
Copy link
Member Author

Yes, I fixed it, but I will refactor it later( #574 )

@krzychu124 krzychu124 merged commit b3e5de6 into master Nov 27, 2019
@originalfoo originalfoo deleted the turkish-lang branch November 27, 2019 21:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Localisation Localised text and features
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants