More advance roundabout quick-setup.

[kianzarrin]

In issue #539 I implemented the first phase of roundabout quick-setup This issue is the next phase to handle stations like this:

Tasks:

• option to setup enter blocked junction for roads joining the roundabout.
• More clever path detection: Instead of following a preferred direction (forward) follow all possible paths in all directions. if the path is not a roundabout then discard it. among the paths that are roundabout I choose the one that has the list amount of left/right turns within the roundabout. if the number of turns are equal then choose the shortest paths With the introduction of road selection panel, this is no longer important.
• short term undo short-term undo for bulk edit tools. #860
• ban parking on roundabout
• Speed Limit Automatically lower speed limits on roundabouts [Suggestion] #793

related : #541 #542

[kianzarrin]

I want to add option to setup entering blocked junctions for roads joining the roundabout. but our options are already a mess (#853) (sorry that's on me!) and I am worried I might make them worse.

So here is what I think:

• in a highway roundabout we want to allow cars to enter blocked junctions
• in an urban roundabout we want cars to yield.

This is what the game does by default. so in theory I don't need to add an option for this. But in practice, when Biffa is fixing cities he has to turn off enter blocked junctions manually because

• sometimes highway roads join urban roundabouts.
• sometimes user has modified enter blocked junction manually before hand.

So I think I need to add option like this:

O modify enter blocked junctions for in-coming cars
   O allow(on)/ ban(off)

[originalfoo]

There's also case where users build their urban roundabouts out of highway roads so they can watch cars driving round them at warp speed.

I suspect road size in terms of lane counts will be a factor, but haven't thought that through yet.

[kianzarrin]

Default settings for entering blocked junctions:

• joining highway : yes
• joining and leaving highway at the same node: No
• urban: No
  
  
  

[originalfoo]

My focus was drawn to the pedestrian crossing icons - on highway roads... Is that a bug?

[kianzarrin]

I suspect road size in terms of lane counts will be a factor, but haven't thought that through yet.

entering blocked junction is good if you are joining the outer lane but not good when you are joining the inner lane (because you can block cars trying to exit the roundabout. so for one lane roundabout is good but for 2+ lane roundabout is bad.

hmmm ... maybe we can have an option in policies to enter blocked junction only for the first lane when pedestrian crossing does not exists.

[originalfoo]

Regardading lane-wise enter-blocked junction, see also: #565

Actually, for enter blocked junction in general, I keep thinking it maybe needs a complete rethink: #424

[kianzarrin]

My focus was drawn to the pedestrian crossing icons - on highway roads... Is that a bug?

I did brought this up int he pull request #845 (comment).

Fixing it would be as easy as setting IsPedestrianCrossingAllowedConfigurable() to false

if the road does has 2+ pedestrian lanes:
    IsPedestrianCrossingAllowedConfigurable = true
    GetDefaultPedestrianCrossingAllowed = true
else if the road to the right has pedestrian lanes AND the road to the left has pedestrian lanes
    // maybe this logic should be more sophisticated to check that the pedestrian lanes is on innder/outter side of the road
    IsPedestrianCrossingAllowedConfigurable = true
    GetDefaultPedestrianCrossingAllowed = true
else
    IsPedestrianCrossingAllowedConfigurable =  false
    GetDefaultPedestrianCrossingAllowed =  false

The GUI automatically does not show pedestrian crossing overlays if they are disabled. Actually in my mod I have patched TMPE to hide pedestrian crossing overlays when appropriate.

[originalfoo]

I split the ped crossing stuff to new ticket ^^

[kianzarrin]

The ticket started with focus on better roundabout detection but now I have abandoned that because road selection panel does the deed.

better roundabout detection should move to another ticket:

• detection and setup of roads that split when joining roundabout.
  • the code for split road setup already exists.
  • my Pedestrian bridge builder already is capable of detecting split roads.
• detection of magic roundabout
  • at every intersection try to see if we can find a mini roundabout. then try to continue on the main roundabout without going through the mini roundabouts.
• graph
  • prefer straight roundabouts.
  • prefer short roundabouts
  • prefer roundabouts without sharp turns

[originalfoo]

Ok, create new ticket.

Should this #578 be closed (treat it as completed by the road selection panel)?

[kianzarrin]

Its working!