The Show error dialog panel can enter a vicious circle

[kianzarrin]

see this #538 (comment)

Summary of the problem:
steps to reproduce:
A: user clicks on a wrong segment.
B: error panel is displayed.
C: user presses OK
D: the user click from step C is captured by the TM tool. However the HoveredSegmentID is not updated. This brings us back to step B.

[originalfoo]

Good catch!

[kianzarrin]

I think this code maybe responsible:

// https://github.com/kianzarrin/Cities-Skylines-Traffic-Manager-President-Edition/blob/09974a08b5d0e3c241351e61d982f1ad31752691/TLM/TLM/UI/TrafficManagerTool.cs#L827
if (mouseRayValid)
{
    HoveredSegmentId = 0;
    HoveredSegmentId = 0;
     ...
     return HoveredNodeId != 0 || HoveredSegmentId != 0;
}
return false; // mouseRayValid=false here

is there any reason why we don't set HoveredSegmentId and HoveredSegmentId to zero when mouseRay is not valid?

[kianzarrin]

setting HoveredSegmentId and HoveredSegmentId to zero does fix the problem :) (see comment above)