Add lane highlight to Vehicle Restrictions tool

[originalfoo]

When user is hovering a vehicle restriction icon, it is sometimes unclear which lane it corresponds to.

That was just an example from my current city; the more common scenario is huge roads with like 24 lanes where you have to start counting rows and lanes to work out what's being changed.

Could we pimp the relevant lane with a highlight to make it completely clear which lane is being altered?

The lane highlight would only be visible while the vehicle restriction icon is hovered.

Suggestion: White highlight (like outgoing lanes on Lane Connector tool) but without the border -a subtle highlight might be sufficient. Alternatively (might be overkill, try white first) the highlight could be coloured similar to the icon border (green or red) showing current state; that way if user hovers green icon the lane is green, they click to apply restriction = icon and lane turn red.

[originalfoo]

Refs: #33

[kianzarrin]

@aubergine10 what is the difference between this and #33 ?

Also suggesting Shift modifier do the same thing as apply to all road toggle.

[originalfoo]

memory loss heh, totally forgot about the earlier issue until after I'd made this one but noticed it later on routine issue trawl and linked it in.

[kianzarrin]

• I manged to put the lane highlight on the top of segment highlight and stop them from blending with each other:
  
• holding shift will turn the lane highlight to yellow.
• Notice the yellow buttons: pressing those buttons while holding shift will apply changes to the whole lane.
• I am planning to do the same with invert
• pressing delete will activate the allow all button and show the 'button is pressed' sprite.
  
• pressing shift+delete will allow all cars on the whole segment. the related GUI button will display yellow color and pressed sprite.

[kianzarrin]

Observation [BUG?]:
Suppose you ban several vehicles on a single segment:

Then you shift click to ban another call vehicle on the whole lane:

You notice that all the OTHER restrictions on the same lane have applied to the rest of the segments but restrictions from other lanes have not applied to the rest of the segments. strange ha?
I consider this to be a bug and I shall fix it :)

[originalfoo]

Yeah, the UI of this tool is a bit weird.

Suggestions:

1. Completely ditch the floating panel - it's confusing and largely obsolete I think?
2. Shift click an icon should only apply the changed state of that icon along the route; other vehicles should be unaffected
   • Example: If I shift+click car to restrict it (red icon state) then the car should be restricted along the route; other vehicle categories on the route would be unchanged.
3. Maybe have a Ctrl key shortcut that works a bit like speed tool - ie. toggles between lane-mode and direction-mode

[kianzarrin]

@aubergine10

Completely ditch the floating panel - it's confusing and largely obsolete I think?

Nooo! I worked so hard to make it useful! I think we need to improve on it.
I think Priority road should also have a panel. in my opinion too many modifier keys with no proper visual feedback is confusing for users. Its better to have a panel that associates each button with a modifier key. if the button is pressed the particular mod is activated (until the button is pressed again). if the modifier key is pressed button texture changes to pressed and the particular mode is activated (until modifier key is released).

EDIT: Maybe have a Ctrl key shortcut that works a bit like speed tool - i.e. toggles between lane-mode and direction-mode

how do you take bus lanes into consideration? I don't think direction mode works for all lane types.

[originalfoo]

If we keep the floating panel, could we at least make it look a bit nicer?

• Ditch invert button, seems pointless
• Replace Ban/Allow all buttons with graphic buttons (similar to speed palette), rough mockup (still not found any remotely decent graphics apps for Windows):

Red with bar version of that icon to 'ban all'. Could be shortcuts for allow/ban (Ctrl+A, Ctrl+B) shown in tooltip of those buttons.

And maybe some button to toggle 'entire route' mode (tooltip would mention Shift key).

[kianzarrin]

Yeah invert is pointless.
if shift (or road mode button) is pressed, lane highlights will become yellow and apply to road's length. the road mode button displays pressed sprite. related buttons show yellow color indicating they influence the whole road.

[kianzarrin]

@aubergine10 I am thinking maybe we do not need this shift modifier at all. I don't think anyone will use it. "apply restriction to entire road" is good enough. we just need to get rid of the invert button.

[originalfoo]

I'd still keep Shift for 'apply to route' as that's consistent with all other tools and to me seems more intuitive than clicking a button on a panel. We can keep the button panel tool (it's looking a lot cleaner now and taking up less space) as some users will prefer that. But personally I'd prefer using shift just like in all other tools.

[kianzarrin]

OK so I will remove the shift GUI button that I just added but the modifier remains.