Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI: Highlight lane when hovering over icons associated with lane #33

Closed
4 tasks done
originalfoo opened this issue Feb 6, 2019 · 12 comments
Closed
4 tasks done
Labels
LANE ROUTING Feature: Lane arrows / connectors medium priority Issue with medium priority of work Overlays Overlays, data vis, etc. PARKING Feature: Parking AI / restrictions / etc SPEED LIMITS Feature: Speed limits UI User interface updates Usability Make mod easier to use VEHICLE RESTRICTIONS Feature: Vehicle restrictions
Projects
Milestone

Comments

@originalfoo
Copy link
Member

originalfoo commented Feb 6, 2019

Sometimes, particularly if various persistent overlays are enabled in mod settings, it's difficult to see which lane a row of vehicle restriction icons belong to. Short rail segments (especially when using 1-lane tracks next to each other) are also sometimes difficult as icons might overlap with infoview icons of adjacent rails.

So, I was wondering if it wold be possible to highlight associated lane when mouse is over an icon, that way it's very clear which lane is being affected when the mouse clicks.

A similar thing could benefit speed restrictions when the individual lane mode is active.

@krzychu124
Copy link
Member

Iirc old Traffic had similar feature, I think.
Currently I have a bit less free time than I expected, but with little effort it should be doable.

Btw it would be nice to collect all visual improvements and enhancements in one patch. What do you think about it?

@originalfoo
Copy link
Member Author

I'd take a more agile approach if possible; push improvements out as they are completed, rather than trying to waterfall it in to big patch. Bu doing incremental updates, if any bugs creep in, there's less code changes to dig through to find them.

That being said, I can spend some time this week doing visual mockups of what the changes might look like; so far they've been described as words but it might be a good ideal to put them in to pixel as a sanity-check that the UI would be viable before making changes to code?

@krzychu124
Copy link
Member

No problem 😉 I've had a plan to release 1.10.15 later this week(maybe even on Friday) after merging with Turn on red feature if I'll find time to check if everything works with that.

Great idea with mockups, would be nice to look how it could look like. Its always easier to make changes on image than in code.

@originalfoo
Copy link
Member Author

Is the 'turn on red' feature optional? a) because some countries don't allow it (eg. UK), and b) if it causes problems users should be able to turn it off while it gets bugfixed.

@krzychu124
Copy link
Member

Yup, I've started testing it yesterday and it's disabled by default IIRC 😉

@originalfoo
Copy link
Member Author

Let me know which mod settings screen (I assume "Maintenance") its on as the docs will need updating. I've added a bunch of stuff to the "Wiki" tab (still lots of stuff missing, broken links, etc) but expect to have bulk of docs finished in a week or two.

@krzychu124
Copy link
Member

'Turn on red' feature toggle is currently located on 'Gameplay' tab under 'Vehicle behavior'. I think that 'Maintenance' could be better but the best would be on 'Policies & Restrictions' under 'At junctions' because its strictly related to this.

What do you think? I can add request to change location to my review of feature pull request 😉

Generally wiki section looks amazing. As you said it still needs some work but besides that I think there are all information they need. In addition I can see you are experienced player and you know this game and mod better than me. Great work!

@originalfoo
Copy link
Member Author

Policies & Restrictions seems best tab IMO. It's a traffic rule (policies & restrictions), rather than a traffic modifier (gameplay) or major feature (maintenance).

@originalfoo originalfoo changed the title Vehicle restrictions & speed limits: Highlight lane when hovering over icons UI: Highlight lane when hovering over icons associated with lane Feb 7, 2019
@originalfoo
Copy link
Member Author

originalfoo commented Feb 7, 2019

Ancient image from Traffic++ showing how lanes can be highlighted.

b01d7a64-ffcc-11e4-93df-d220047e19dc

So far, I can see this sort of highlighting being useful for:

  • Parking restrictions
  • Vehicle restrictions
  • Lane arrows / Lane connector
  • Timed traffic lights
  • Speed limits
  • It could even be useful for junction restrictions and priority signs...

Although it could get annoying so possibly some setting in global config or mod settings to choose which tools it applies to?

@krzychu124 krzychu124 added medium priority Issue with medium priority of work Usability Make mod easier to use labels Feb 7, 2019
@krzychu124
Copy link
Member

Moar settings and options 🤣
I've had similar image in my mind when I saw topic of this issue. Could you post again link to source of Traffic++. I can't find it because you've added too many issues 😆

@originalfoo
Copy link
Member Author

When using with timed traffic lights, or when using with 'all segments between two junctions' key modifiers on other tools, it would need ability to highlight one or more lanes along multiple segments.

T++ source: https://github.com/joaofarias/csl-traffic

@originalfoo originalfoo added LANE ROUTING Feature: Lane arrows / connectors JUNCTION RESTRICTIONS Feature: Junction restrictions PARKING Feature: Parking AI / restrictions / etc VEHICLE RESTRICTIONS Feature: Vehicle restrictions SPEED LIMITS Feature: Speed limits Overlays Overlays, data vis, etc. labels Aug 12, 2019
@originalfoo originalfoo removed the JUNCTION RESTRICTIONS Feature: Junction restrictions label Feb 24, 2020
@originalfoo
Copy link
Member Author

Closing this as it's basically complete but via several issues:

The traffic lights lane highlighting is tracked by at least one separate issue already so no need to keep this #33 open.

@originalfoo originalfoo modified the milestones: UI improvements, 11.1.1 Feb 24, 2020
@kvakvs kvakvs moved this from Task queue to Done in New UI Apr 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
LANE ROUTING Feature: Lane arrows / connectors medium priority Issue with medium priority of work Overlays Overlays, data vis, etc. PARKING Feature: Parking AI / restrictions / etc SPEED LIMITS Feature: Speed limits UI User interface updates Usability Make mod easier to use VEHICLE RESTRICTIONS Feature: Vehicle restrictions
Projects
Development

No branches or pull requests

3 participants