-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Priority Signs: Interaction model is whack #77
Comments
assigning to self to do the trash icon |
Looks good 😉 |
New remove_signs icon - updates #77
related to #541 |
There have been loads of good improvements to the priority signs stuff, but the user interaction for editing is still a bit weird because there are two interaction models depending on whether a junction is already customised or not:
That, in a nutshell, is why it is clunky to use. There should be only one interaction model, regardless of whether the junction is customised or not. I think, in particular, user should always have to "select junction" to make changes. And to revert to default it should be In OP I pondered user being able to click overlay icon to cycle the sign + go in to junction edit mode. However, that would be weird too (imagine tryying to make that viable for all the other tools that show only "changes from default" icons). |
We can plan this after UI tools are modified
|
I've been working on docs for priority signs feature, and realised the interaction model of that feature is not consistent with other junction-related tools.
In particular, with a junction selected (that has a sign added to at least one of its roads), I should be able to right-click to deselect that junction.
When a junction is deselected, the red X button in the middle should be hidden. This will reduce risk of accidental settings deletions (useful if you have shit mouse, like I do, or a disability), especially when working with close-proximity junctions.
Also, due to the selection/deselection weirdness, the red-X button, considering where it's placed, can be mistaken for a "close" button by new users. While I love the simplicity of the holy shit, house down the road from me has installed a wind turbine! Uhm, I love the simplicity of the red X button, but maybe having a trash can icon would be better?
Suggestions:
Note: If Eraser tool is implemented at later date (see #38 for brief info), it's possible the trash button could be ditched to further simplify on-screen UI.
The text was updated successfully, but these errors were encountered: