Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should TrafficManager.dll be copied to deploy dir twice? #775

Closed
originalfoo opened this issue Mar 3, 2020 · 1 comment · Fixed by #776
Closed

Should TrafficManager.dll be copied to deploy dir twice? #775

originalfoo opened this issue Mar 3, 2020 · 1 comment · Fixed by #776
Assignees
Labels
BUG Defect detected confirmed Represents confirmed issue or bug
Milestone

Comments

@originalfoo
Copy link
Member

This is post-build script for TLM project (using - diff formatting to highlight applicable lines):

set "DEPLOYDIR=$(LOCALAPPDATA)\Colossal Order\Cities_Skylines\Addons\Mods\$(TargetName)\"
- xcopy /y "$(TargetDir)TrafficManager.dll" "%DEPLOYDIR%"
xcopy /y "$(TargetDir)TMPE.CitiesGameBridge.dll" "%DEPLOYDIR%"
xcopy /y "$(TargetDir)TMPE.GenericGameBridge.dll" "%DEPLOYDIR%"
xcopy /y "$(TargetDir)TMPE.API.dll" "%DEPLOYDIR%"
xcopy /y "$(TargetDir)CSUtil.CameraControl.dll" "%DEPLOYDIR%"
xcopy /y "$(TargetDir)TMPE.RedirectionFramework.dll" "%DEPLOYDIR%"
xcopy /y "$(TargetDir)CSUtil.Commons.dll" "%DEPLOYDIR%"
xcopy /y "$(TargetDir)0TMPE.Harmony.dll" "%DEPLOYDIR%"

rem To avoid double hot reload, TrafficManager.dll must be replaced last and fast. 
rem Once TrafficManager.dll is re-loaded, all other dlls will be reloaded as well
del  "%DEPLOYDIR%TrafficManager.dll"
- xcopy /y "$(TargetDir)TrafficManager.dll" "%DEPLOYDIR%"    

echo THE ASSEMBLY VERSION IS: @(VersionNumber) created at %time%
set DEPLOYDIR=
@originalfoo originalfoo added BUG Defect detected triage Awaiting issue categorisation labels Mar 3, 2020
originalfoo added a commit that referenced this issue Mar 3, 2020
Pretty sure there's no point copying over TrafficManager.dll twice - see #775
@kianzarrin kianzarrin assigned originalfoo and unassigned kianzarrin Mar 5, 2020
@kianzarrin
Copy link
Collaborator

Sorry my bad!

@originalfoo originalfoo added confirmed Represents confirmed issue or bug and removed triage Awaiting issue categorisation labels Mar 5, 2020
@originalfoo originalfoo added this to the 11.2 milestone Mar 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BUG Defect detected confirmed Represents confirmed issue or bug
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants