Deprecated SpiralLoop cleanup. #1019
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removed the SpiralLoop method. Adjusted unit- and performance tests. performance tests should use a mono path that should be more common for CSL.
DaEgi01
added
the
code cleanup
kvakvs
approved these changes
Oct 28, 2020
| for (int i = 0; i < 10; i++) { | ||
| var coords = spiral.GetCoords(radius); | ||
| for (int j = 0; j < coords.Count; j++) { | ||
| var coord = coords[j]; |
There was a problem hiding this comment.
Afraid this will be optimized out by the compiler but okay, if you're testing the generation code not the loop code.
There was a problem hiding this comment.
Well, the perf tests were there to confirm that a) the implementation is more performant than the previous one and b) that the spiral class does not generate any garbage in the GetCoords call that is used in the gameloop.
I left the test there to verify b) and as a baseline should anyone wish to create an even better implementation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed the SpiralLoop method.
Adjusted unit- and performance tests.
Performance tests should use a mono path that should be more common for CSL.