Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Right click to close main menu or exit current tool #1032

Merged
merged 3 commits into from
Nov 14, 2020
Merged

Right click to close main menu or exit current tool #1032

merged 3 commits into from
Nov 14, 2020

Conversation

krzychu124
Copy link
Member

Closes #1014

Compiled version for tests

New:

  • right click to close main menu if no other tool active
  • right click to exit currently active tool

Improvements for existing code:

  • fixed variable, local parameter name collisions

@krzychu124 krzychu124 added enhancement Improve existing feature Annoyance Not a bug, but just as annoying Usability Make mod easier to use Toolbar The main TMPE toolbar labels Nov 11, 2020
@krzychu124 krzychu124 added this to the 11.6.0 milestone Nov 11, 2020
@krzychu124 krzychu124 requested a review from a team November 11, 2020 22:49
@krzychu124 krzychu124 self-assigned this Nov 11, 2020
@krzychu124 krzychu124 added the Keybinds Keyboard (and mouse) shortcuts label Nov 11, 2020
kvakvs
kvakvs approved these changes Nov 12, 2020
View reviewed changes
Copy link
Collaborator

@kvakvs kvakvs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good stuff

kianzarrin
kianzarrin approved these changes Nov 12, 2020
View reviewed changes
Copy link
Collaborator

@kianzarrin kianzarrin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the code LGTM

TLM/TLM/Manager/Impl/RoutingManager.cs Show resolved Hide resolved
@kianzarrin
Copy link
Collaborator

the only caveat is when no tool is active but the user has selected a road
image
right-clicking at this point exists tool as oppose to closing the road info panel.

@krzychu124
Copy link
Member Author

the only caveat is when no tool is active but the user has selected a road

Good point, it's driven by separate logic (cool spaghetti), I'll fix it 🙃

@krzychu124
Copy link
Member Author

I've implemented fix for closing road selection panel on single right click, @chameleon-tbn your turn and I'll merge if you won't find anything else. Good addition to Stable 11.5

@chameleon-tbn
Copy link
Contributor

chameleon-tbn commented Nov 13, 2020 •
edited

I'll test today in full modded game :)

@chameleon-tbn
Copy link
Contributor

I've tested now in a game with 135 Mods, 10k assets. All seems to work as expected - even if i really need to 'relearn' using the right click in the correct way :) 1x = closing actual activated UI, 2x = leave the actual selected button, 3x = completely close TM:PE UI... really handy... i like :) a go from me :)

chameleon-tbn
chameleon-tbn approved these changes Nov 13, 2020
View reviewed changes
Copy link
Contributor

@chameleon-tbn chameleon-tbn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@krzychu124 krzychu124 merged commit a482742 into master Nov 14, 2020
@krzychu124 krzychu124 deleted the 1014-RMB-exit-tool-close-menu branch April 10, 2021 23:57
@originalfoo originalfoo modified the milestones: 11.6.0, 11.5.1 Jan 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kvakvs kvakvs kvakvs approved these changes

@kianzarrin kianzarrin kianzarrin approved these changes

@chameleon-tbn chameleon-tbn chameleon-tbn approved these changes

Assignees

@krzychu124 krzychu124

Labels
Annoyance Not a bug, but just as annoying enhancement Improve existing feature Keybinds Keyboard (and mouse) shortcuts Toolbar The main TMPE toolbar Usability Make mod easier to use
Projects
None yet
Milestone
11.5.1
Development

Successfully merging this pull request may close these issues.

Close TM:PE menu on right click, similar to Node Controller and Intersection Marking Tool
5 participants
@krzychu124 @kianzarrin @chameleon-tbn @kvakvs @originalfoo