Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Monitor.Enter/Exit changes #1048

Merged
merged 1 commit into from
Jan 10, 2021
Merged

Monitor.Enter/Exit changes #1048

merged 1 commit into from
Jan 10, 2021

Conversation

krzychu124
Copy link
Member

It was suspicious, seem to help with crashing/sim lock when the mod is running on the Linux OS(#817)

Replaced Monitor.Enter(<lock_obj>)/Exit with lock(<lock_obj>){ }

@krzychu124 krzychu124 added enhancement Improve existing feature technical Tasks that need to be performed in order to improve quality and maintainability code cleanup Refactor code, remove old code, improve maintainability labels Jan 3, 2021
@krzychu124 krzychu124 self-assigned this Jan 3, 2021
DaEgi01
DaEgi01 approved these changes Jan 3, 2021
View reviewed changes
Copy link
Contributor

@DaEgi01 DaEgi01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes plz

kvakvs
kvakvs approved these changes Jan 9, 2021
View reviewed changes
Copy link
Collaborator

@kvakvs kvakvs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

@krzychu124 krzychu124 merged commit c666d54 into master Jan 10, 2021
@krzychu124 krzychu124 deleted the improvement/resource-locking branch April 10, 2021 23:56
@originalfoo originalfoo added this to the 11.6.0 milestone Jan 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kvakvs kvakvs kvakvs approved these changes

@DaEgi01 DaEgi01 DaEgi01 approved these changes

Assignees

@krzychu124 krzychu124

Labels
code cleanup Refactor code, remove old code, improve maintainability enhancement Improve existing feature technical Tasks that need to be performed in order to improve quality and maintainability
Projects
None yet
Milestone
11.6.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@krzychu124 @kvakvs @DaEgi01 @originalfoo