cleaning up life cycle code #1068
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
removed OnCreated OnRelease for better hot reload.
cleanup Patcher. polish loading/unloading code.
kianzarrin
added
the
code cleanup
DaEgi01
approved these changes
Apr 8, 2021
kvakvs
approved these changes
Apr 8, 2021
There was a problem hiding this comment.
Changing ClassName.Instance.Field to be static and using a shorter ClassName.Field is just trading a static (Instance is static) for another static (Field is now static), so there is no change and no step back. But the code using it might indeed look better.
The 🦭 of approval is unsure but rather approves.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related: #767
Intro:
CS recreates all ILoadingExtensions/ISerializableDataExtensions for ALL mods any time ANY mod is hot-swapped. therefore it is a bad idea to rely on a particular instance of such classes. Also, OnCreated/OnRelease are not meaningful.
changes:
Test passed:
start new game -> load saved game -> hot reload -> load saved game -> exit to main manu -> load saved game