-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
730 cleanup loading custom path manager #1072
Conversation
removed OnCreated OnRelease for better hot reload.
cleanup Patcher. polish loading/unloading code.
hot unload now works
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Formatting is off the rails.
I believe some debug log messages have no value (the operations cannot fail, and the time they appear in log is not helping anything, just noise).
@kvakvs I fixed the spaces and remove most debug logs. but I think it is a good idea to keep the debug logs that help us track CustomPathManager VS Stock PathManager. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
fixes #730
Test passed:
https://ci.appveyor.com/api/projects/krzychu124/tmpe/artifacts/TMPE.zip?branch=730-cleanup-loading-CustomPathManager
blocks #1076 #1077