Citizen not found fix #1091
Merged
Citizen not found fix #1091
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ag 'TargetIsNode' used to distinguish m_targetBuilding is (flag indicates that is Node ID, not Building ID)
krzychu124
added
BUG
kvakvs
approved these changes
Apr 19, 2021
|
@kvakvs It's just one missing flag(added in the ParkLife DLC). Since not all flags are used there to reset I could experiment with "subtracting not allowed flags from |
DaEgi01
approved these changes
Apr 24, 2021
If they'll change anything there it will be broken anyways. I'm merging it, it's the time to push it for tests. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Incomplete flag reset was clearing important flag
CitizenInstance.Flags.TargetIsNodeused to distinguish type of ID stored.Flag indicates that value of
CitizenInstance.m_targetBuildingis Node ID, not Building ID - Node ID is used for all kind of public transport stops including node of walking tour. Warning about wrong Citizen was triggered because citizen reached last walking tour path node, close to his parked vehicle - cim requests for additional path to reach vehicle.Test build available here (requires CitiesHarmony mod unlike workshop versions)
Resolves #1067