Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dedicated turning lane policy #1104

Merged
merged 23 commits into from
May 12, 2021
Merged

Conversation

kianzarrin
Copy link
Collaborator

@kianzarrin kianzarrin commented May 6, 2021

fixes #1102 see #1102

A) I changed dedicated turning lanes behavior for bus lanes:

  • mode 1: bus lanes are considered part of car lanes. (same as before)
    mode 2: bus lanes are treated differently (changed: they are given a forward arrow)

B) I added a builtIn mode to change default lane arrow values as opposed to forced values.

image

  • add to crowdin
    image

depends on #1096 (I merged it with #1096 because I wanted to test my code using hot reload),

@kianzarrin
Copy link
Collaborator Author

except for crowdin, this is ready for review.

@kianzarrin kianzarrin requested a review from DaEgi01 May 6, 2021 19:07
Copy link
Collaborator

@kvakvs kvakvs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

@kianzarrin kianzarrin linked an issue May 7, 2021 that may be closed by this pull request
@kianzarrin kianzarrin added enhancement Improve existing feature feature A new distinct feature LANE ROUTING Feature: Lane arrows / connectors MASS EDIT The mass edit tool labels May 7, 2021
@kianzarrin kianzarrin marked this pull request as ready for review May 7, 2021 04:05
@kianzarrin kianzarrin added the Dependent This issue is blocked by another issue. label May 7, 2021
added crowdin key
@kianzarrin
Copy link
Collaborator Author

this is how it looks like with TTL
image

@kianzarrin
Copy link
Collaborator Author

kianzarrin commented May 7, 2021

All in all, I found a couple of caveats:


here it's better to have 2 right turns:
image
notes:

  • this is not a problem with the "dedicated turning lane" policy.
  • user can alt-click with the lane-arrow tool to fix it.

in these 2 cases, It's better two have an extra dedicated right turn:
image
notes:

  • this is not a problem with the "dedicated turning lane" policy.
  • user can alt-click with the lane-arrow tool to fix it.

here (dedicated turning lane policy) it's better to have two right turns.
image

  • this is not a problem with the "auto-TLL"
  • use can alt-click with the lane-arrow tool to fix it.

to fix the caveats with the Auto-TTL turning lanes I can do this:

if altBus:
    SeparateTurningLanes(car+bus lanes) // current code
    // add this code
    if car lanes >= turn directions:
        SeparateTurningLanes(car lanes alone)

to fix the last caveat (policy) I can do this:

if no right turn and has only one bus lane to the right:
    do not treat bus lanes differently.
else:
    proceed as normal.

@kianzarrin kianzarrin marked this pull request as draft May 7, 2021 08:17
@kianzarrin
Copy link
Collaborator Author

kianzarrin commented May 7, 2021

I should also test with roads where the inner most lane is a bus lane.

@kvakvs
Copy link
Collaborator

kvakvs commented May 7, 2021

When you have not enough outgoing lanes on a T junction, it is a valid choice to have one lane going both left and right. The traffic will not cross each other but they might somehow get confused and prefer that lane over 1 direction lanes?

image
Here example: T junction where road has LEFT ONLY lane and LEFT+RIGHT lane, going onto motorway. It works. There is also a traffic light.

@kianzarrin
Copy link
Collaborator Author

@kvakvs one lane going both left and right

Sure but when the user activates dedicated turning lane policy, he probably wants dedicated turning lanes :)

@kianzarrin
Copy link
Collaborator Author

more bus roads (I added bus lane props):
image
the marked section in the image above might be debatable. but I think its good (at least good enough)

@kianzarrin
Copy link
Collaborator Author

kianzarrin commented May 8, 2021

If user activates the "ban cars on bus lanes" option there could be a bit of a problem (with or without dedicated turning lane policy)
image

but I think that should be outside of the scope of this review.

@kianzarrin
Copy link
Collaborator Author

kianzarrin commented May 8, 2021

and this is with timed traffic lights
image
I don't see any additional problems with the middle lanes.

@kianzarrin
Copy link
Collaborator Author

On the second though I am not so sure about this
image
if I do change these lanes to turning lanes, then the buses that want to go forward have to change multiple lanes to get to the forward lane.

@kianzarrin kianzarrin marked this pull request as ready for review May 9, 2021 08:52
@DaEgi01
Copy link
Contributor

DaEgi01 commented May 9, 2021

this is how it looks like with TTL
image

here are some "issues" where the lanes break at least my expectation.

dedicated_bus_lanes_expectation

that is ... if the bus lanes are supposed to be dedicated.
if not, forget my screen.

Base automatically changed from 1095-asset-lifecycle to master May 12, 2021 20:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Dependent This issue is blocked by another issue. enhancement Improve existing feature feature A new distinct feature LANE ROUTING Feature: Lane arrows / connectors MASS EDIT The mass edit tool
Projects
None yet
Development

Successfully merging this pull request may close these issues.

dedicated turning lane policy
5 participants