EnumerateSpeedLimits in OnToolGUI .... #1149
Conversation
- Removed SpeedUnit.CurrentlyConfigured because that is not a speed unit. - Added GlobalConfig.Main.GetDisplaySpeedUnit() method to get SpeedUnit from user config directly. - Added SpeedValue.Unlimited() convenience method for better expressing intent. - Removed EnumerateSpeedLimits from OnToolGUI in SpeedLimitsTool. The values should be generated once and reused since they don't change during runtime.
| @@ -68,6 +68,8 @@ public static SpeedValue FromMph(ushort mph) | |||
| public static SpeedValue FromMph(MphValue mph) | |||
| => new SpeedValue(mph.Mph / ApiConstants.SPEED_TO_MPH); | |||
|
|
|||
| public static SpeedValue Unlimited() => new SpeedValue(0); | |||
There was a problem hiding this comment.
I think we use speed value 20f as Unlimited (1000 km/h). 0f has some different meaning.
There was a problem hiding this comment.
Check GetPrevious and GetNext and
SpeedLimitsTool:636 before change
allSpeedLimits.Add(new SpeedValue(0)); // add last item: no limit
Unlimited() is basically a replacement for that.
There was a problem hiding this comment.
0 is used to display 🚫 in the speed palette
this is not the same as 20f used as unlimited. And i would prefer unlimited constant to be 20f.
There was a problem hiding this comment.
so "no limit" is not the same as "unlimited"?
isn't 🚫 the sign for unlimited speed?
I am confused.
There was a problem hiding this comment.
0 is texture index for 🚫
20f is used to set the speed limit to Unlimited
you gave name Unlimited to 0f which is wrong
the value 0f in speed palette should be converted to 20f somewhere in the code, that's the confusing moment.
There was a problem hiding this comment.
so functions like ToKmphPreciseString are wrong too?
can you show me where this 20f is? can't find it.
There was a problem hiding this comment.
SpeedLimitManager::MAX_SPEED = 10f * 2f
SpeedLimitManager::ToGameSpeedLimit() and ::IsValidRange()
There was a problem hiding this comment.
From the current master branch
and also
The values should be generated once and reused since they don't change during runtime.