Closure killer iterate segment lanes #1162
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sed enumerator that returns LaneId and LaneIndex.
…rect foreach and as a base line for further improvement.
# Conflicts: # TLM/TLM/State/Flags.cs # TLM/TLM/Traffic/Impl/SegmentEnd.cs Also did a rename from LaneIdAndLaneIndex to LaneIdAndIndex.
|
is this code used in performance critical part of the code? |
I think so. I'd have to double check since I made the changes some time ago. |
kvakvs
approved these changes
Oct 3, 2021
|
|
||
| [Benchmark] | ||
| public void Foreach_Direct() { | ||
| foreach (var item in new GetSegmentLaneIdsEnumerable(0, testLanes.Length, testLanes)) { |
There was a problem hiding this comment.
Does that by any reason get optimized out? Or you benchmark in debug mode?
There was a problem hiding this comment.
Empty loop body could be optimized out? Not sure how C# compiler handles empty loops
There was a problem hiding this comment.
Foreach won't be optimized because it may have side effects
originalfoo
added
the
code cleanup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Killed IterateSegmentLanes with struct enumerators to simplify code and remove heap allocations.