Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Trains not counted as waiting - Timed Traffic Lights #1184

Merged
merged 4 commits into from
Oct 31, 2021
Merged

Trains not counted as waiting - Timed Traffic Lights #1184

merged 4 commits into from
Oct 31, 2021

Conversation

krzychu124
Copy link
Member

Fixes #1173

  • wrong label target resulted in completely skipped code at normal conditions.
  • added missing call to ForceTrafficLights() (I think I forgot to fix that while migrating to Harmony)

@krzychu124 krzychu124 added BUG Defect detected confirmed Represents confirmed issue or bug TRAFFIC LIGHTS Feature: Traffic lights - toggle, timed, etc regression old bug comes back or a new bug introduced in code that used to work. labels Oct 31, 2021
@krzychu124 krzychu124 added this to the 11.6.0 milestone Oct 31, 2021
@krzychu124 krzychu124 self-assigned this Oct 31, 2021
@DaEgi01 DaEgi01 merged commit 307d50e into master Oct 31, 2021
@krzychu124 krzychu124 mentioned this pull request Jan 8, 2022
Merged
@originalfoo originalfoo modified the milestones: 11.6.0, 11.6.2 Jan 18, 2022
@originalfoo originalfoo deleted the 1173-trains-not-counted-as-waiting-ttl branch January 18, 2022 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kvakvs kvakvs kvakvs approved these changes

@DaEgi01 DaEgi01 DaEgi01 approved these changes

@chameleon-tbn chameleon-tbn Awaiting requested review from chameleon-tbn

@kianzarrin kianzarrin Awaiting requested review from kianzarrin

Assignees

@krzychu124 krzychu124

Labels
BUG Defect detected confirmed Represents confirmed issue or bug regression old bug comes back or a new bug introduced in code that used to work. TRAFFIC LIGHTS Feature: Traffic lights - toggle, timed, etc
Projects
None yet
Milestone
11.6.2
Development

Successfully merging this pull request may close these issues.

Trains are not counted as waiting at timed traffic lights at rail junctions
4 participants
@krzychu124 @kvakvs @DaEgi01 @originalfoo