improve lifecycle of TMPE tool #1188
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ensure GetTrafficMangerTool is created after startup.
removed redundant code enabling disabling TMPE does not change info view.
krzychu124
requested changes
Nov 8, 2021
kvakvs
approved these changes
Nov 9, 2021
krzychu124
approved these changes
Nov 9, 2021
enable tool in start method.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
UUI button is created when TMPE tool is created so we need this to be created on startup. also the Road selection panels need it. for this reason I ensure TMPE tool is created as soon as game is loaded.
Additionally there was a buggy recursion issue when TMPE tool is enabled for the first time outside of EnableTool(). I solved it by only creating the TMPE tool inside EnableTool() and making the function private.
This will not only get rid of hackish code in RoadSelectionPanels but also solve the issue that UUI button is not created in asset editor.
PS: I also had to change a transpiler. instead of modifying il instructions I called a function instead which is easier to maintain.
TMPE.zip