Remove NetService and the GameBridge stuff #1194
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Moved GetNodeSegmentIds out of NetService into ExtNodeManager. Moved GetInitialSegment out of NetService into ExtNodeManager. Moved ClockDirection out of INetService.cs into its own file in TrafficManager.Impl Namespace.
Moved NetService GetSegmentLaneIdsAndLaneIndexes into ExtSegmentManager. Moved GetSegmentLaneIdsEnumerable into TrafficManager.Manager.Impl namespace. Moved GetSegmentLaneIdsEnumerator into TrafficManager.Manager.Impl namespace. Moved LaneIdAndIndex TrafficManager.Manager.Impl namespace.
Moved NetService GetSortedLanes into ExtSegmentManager. Moved LanePos into TrafficManager.Manager.Impl namespace.
Removed empty NetService. Deleted now empty GenericGameBridge project. Deleted now empty CitiesGameBridge project.
|
@DaEgi01, I've fixed build pipeline, restarted builds 😉 |
krzychu124
approved these changes
Nov 14, 2021
krzychu124
added
the
code cleanup
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
see individual commits.