GetNode/Segment -> ToNode/Segment #1202
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GetNode(nodeID) with ToNode() GetSeg(segmentID) with ToSegment() renamed: GetNode(segment, startNode) to GetNodeID(segment, startNode)
DaEgi01
requested changes
Nov 23, 2021
| @@ -71,7 +71,7 @@ public class LaneConnectionManager | |||
| private bool IsHeadingTowardsStartNode(uint sourceLaneId) { | |||
| NetLane[] laneBuffer = NetManager.instance.m_lanes.m_buffer; | |||
| ushort segmentId = laneBuffer[sourceLaneId].m_segment; | |||
| NetSegment segment = GetSeg(segmentId); | |||
| NetSegment segment = segmentId.ToSegment(); | |||
There was a problem hiding this comment.
you should take a look at macsurgeys code! he refuses to use ref as a matter of principle!
There was a problem hiding this comment.
haha lol, it does not mean we should not do better though :) what was the sizeof(NetSegment) again? can't check atm.
There was a problem hiding this comment.
I was just kidding!
@DaEgi01 In any case if you didn't notice I already fixed it.
krzychu124
approved these changes
Nov 24, 2021
DaEgi01
approved these changes
Nov 24, 2021
originalfoo
added
the
code cleanup
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GetNode(nodeID) with ToNode()
GetSeg(segmentID) with ToSegment()
renamed:
GetNode(segment, startNode) to GetNodeID(segment, startNode) because the return value is ushort not ref NetNode