fix uturn policy on T junctions #1212
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kianzarrin
added
BUG
kianzarrin
commented
Dec 2, 2021
| @@ -1968,7 +1967,7 @@ bool laneChangesAllowed | |||
| // force u-turns to happen on the innermost lane | |||
| ++compatibleLaneDist; | |||
| nextCompatibleTransitionDatas[nextTransitionIndex].type = | |||
| LaneEndTransitionType.Relaxed; | |||
| LaneEndTransitionType.Relaxed; // TODO : normal when u-turn allowed | |||
There was a problem hiding this comment.
ignore this. I deleted this comment in the next commit
krzychu124
approved these changes
Dec 2, 2021
DaEgi01
approved these changes
Dec 3, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #347
fixes #900
2 commits:
1st commit : simplifies code without any effective change the code.
2nd commit: fixes the u-turn issue
here U-turn routing of type
LaneEndTransitionType.Defaulthappens if it is a junction with 2 segments but not when it is a junction with 3 segments.TMPE/TLM/TLM/Manager/Impl/RoutingManager.cs
Line 907 in a7d6446
note :
nextIsRealJunction = nextNode.CountSegments() >= 3So basically what this means is we have the picture bellow:
an orange relaxed u-turn routing on one side and a green default u-turn routing on the other side
How to test:
TMPE build: https://ci.appveyor.com/api/projects/krzychu124/tmpe/artifacts/TMPE.zip?branch=T-uturn-347
We can use bus stops to see if u-turn is possible. By using the "Buses may ignore lane arrows" policy we can test relaxed/default lane routing.
Buses may Ignore lane arrows policy (in original TMPE. this PR fixes this) = off
Buses may Ignore lane arrows policy = on
