Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update routings after modifying dedicated turning lanes policy #1236

Merged
merged 4 commits into from
Dec 20, 2021

Conversation

kianzarrin
Copy link
Collaborator

fixes #1235 (see issue)

Tested and works in game. after deleted all cars new paths will obey dedicated lane arrows.
it is also pretty fast in 655k city (a few seconds)

@kianzarrin kianzarrin self-assigned this Dec 18, 2021
@kianzarrin kianzarrin added the LANE ROUTING Feature: Lane arrows / connectors label Dec 18, 2021
@@ -54,9 +54,9 @@ public static class PlaceIntersectionUtil {
Asset2Data.Select(item => item.Key).ToSTR());

if (Asset2Data.TryGetValue(intersectionInfo, out var assetData)) {
Log.Info("PlaceIntersectionUtil.ApplyTrafficRules(): assetData =" + assetData);
Log._Debug("PlaceIntersectionUtil.ApplyTrafficRules(): assetData =" + assetData);
} else {
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just removing log spam here. no need to print this for all assets on load

Copy link
Member

@originalfoo originalfoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@kianzarrin kianzarrin added this to the 11.6.0 milestone Dec 19, 2021
@kianzarrin kianzarrin added this to In progress in Make TM:PE Great Dec 19, 2021
@kianzarrin kianzarrin removed this from In progress in Make TM:PE Great Dec 19, 2021
Copy link
Collaborator

@kvakvs kvakvs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fine

@kianzarrin kianzarrin merged commit 43f7b2a into master Dec 20, 2021
@kianzarrin kianzarrin deleted the 1235-update-dedicated-routings branch December 20, 2021 01:07
@krzychu124 krzychu124 mentioned this pull request Jan 8, 2022
@originalfoo originalfoo modified the milestones: 11.6.0, 11.6.2 Jan 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
LANE ROUTING Feature: Lane arrows / connectors
Projects
None yet
Development

Successfully merging this pull request may close these issues.

dedicated turning lane policy is only applied superficially
3 participants