Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix position of lane arrow tool for different resolutions. #1237

Merged
merged 2 commits into from
Dec 19, 2021
Merged

fix position of lane arrow tool for different resolutions. #1237

merged 2 commits into from
Dec 19, 2021

Conversation

kianzarrin
Copy link
Collaborator

for resolution other than FHD, lane arrow tool would not appear in the right place. I fixed the code.

  • I put the code in the base class to avoid duplicate code in future.
  • deleted some commented out code that kvakvs forgot to delete.
  • I tested will various resolutions, aspect ratios, UI Scale, and UI resolution mod. All tests pass

@kianzarrin kianzarrin added BUG Defect detected UI User interface updates labels Dec 18, 2021
@kianzarrin kianzarrin added this to the 11.6.0 milestone Dec 18, 2021
@kianzarrin kianzarrin self-assigned this Dec 18, 2021
kvakvs
kvakvs approved these changes Dec 19, 2021
View reviewed changes
Copy link
Collaborator

@kvakvs kvakvs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

originalfoo
originalfoo approved these changes Dec 19, 2021
View reviewed changes
Copy link
Member

@originalfoo originalfoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@kianzarrin kianzarrin added this to In progress in Make TM:PE Great Dec 19, 2021
@kianzarrin kianzarrin added this to In progress in New UI Dec 19, 2021
@kianzarrin kianzarrin merged commit 75a077b into master Dec 19, 2021
@kianzarrin kianzarrin deleted the lane-arrow-tool-position branch December 19, 2021 20:08
@kianzarrin kianzarrin removed this from In progress in Make TM:PE Great Dec 19, 2021
@originalfoo originalfoo moved this from In progress to Done in New UI Dec 19, 2021
@krzychu124 krzychu124 mentioned this pull request Jan 8, 2022
Merged
@originalfoo originalfoo modified the milestones: 11.6.0, 11.6.2 Jan 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kvakvs kvakvs kvakvs approved these changes

@originalfoo originalfoo originalfoo approved these changes

@DaEgi01 DaEgi01 Awaiting requested review from DaEgi01

@krzychu124 krzychu124 Awaiting requested review from krzychu124

@chameleon-tbn chameleon-tbn Awaiting requested review from chameleon-tbn

Assignees

@kianzarrin kianzarrin

Labels
BUG Defect detected UI User interface updates
Projects
New UI
Done
Milestone
11.6.2
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@kianzarrin @kvakvs @originalfoo