Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed regression: Auto TTL should set-up dedicated turning lanes properly #1242

Merged
merged 2 commits into from
Dec 27, 2021

Conversation

kianzarrin
Copy link
Collaborator

@kianzarrin kianzarrin commented Dec 20, 2021

fixes #1241
updates #1106

Changes:

Bonus changes:

  • if cars are banned on bus lanes they are treated separately when allocating dedicated turning lanes (except single lane roads which are out of scope of this PR):
  • if someone turns on the "ban cars on bus lanes" policy while "dedicated turning lanes" policy is on, then lane arrows are updated.

Scope:
This PR is meant to be a tiny fix and more complicated stuff are outside of the scope:


Test City: see #1241 (comment)
TMPE.zip

dedicated turning lanes takes into account the "cars on bus lanes" policy.
@kianzarrin
Copy link
Collaborator Author

Test:

dedicated turning lane policy when cars are banned on bus lanes:
image

TTL when cars are banned on bus lanes:
image

@originalfoo
Copy link
Member

if someone bans cars on bus lanes while dedicated turning lanes policy is on, lane arrows are not updated (should I handle this in this PR or should I keep the changes small?)

separate PR imo

Copy link
Member

@originalfoo originalfoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good, tested in game for 10 mins and didn't see any issues relating to PR.

@kianzarrin
Copy link
Collaborator Author

if someone bans cars on bus lanes while dedicated turning lanes policy is on, lane arrows are not updated (should I handle this in this PR or should I keep the changes small?)

separate PR imo

Now that I look at it, this takes only a couple of lines so I just added the code.

@kianzarrin kianzarrin added high priority Affects lots of users LANE ROUTING Feature: Lane arrows / connectors TRAFFIC LIGHTS Feature: Traffic lights - toggle, timed, etc Settings Road config, mod options, config xml labels Dec 20, 2021
@originalfoo
Copy link
Member

if someone bans cars on bus lanes while dedicated turning lanes policy is on, lane arrows are not updated

Tested after the additional code tweak; everything seems working in-game. 👍

Copy link
Contributor

@chameleon-tbn chameleon-tbn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested today, Played ~2 hours w/o issues. So... I give it a Go :)

Copy link
Member

@krzychu124 krzychu124 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@kianzarrin kianzarrin merged commit 0c010d3 into master Dec 27, 2021
@kianzarrin kianzarrin deleted the 1241-TTL-dedicated-lanes branch December 27, 2021 22:42
@krzychu124 krzychu124 mentioned this pull request Jan 8, 2022
@originalfoo originalfoo modified the milestones: 11.6.0, 11.6.2 Jan 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
high priority Affects lots of users LANE ROUTING Feature: Lane arrows / connectors Settings Road config, mod options, config xml TRAFFIC LIGHTS Feature: Traffic lights - toggle, timed, etc
Projects
None yet
4 participants