New countries for speed limit designs

[kvakvs]

Fixes #1251

• New speed limit themes for multiple countries
• Priority signs and parking signs also included in the theme

I have checked Steam popularity per country, skipped countries which are very similar to German and existing British road signs, and figured out we can add 5 new country themes:

• Sweden 🇸🇪 (because i live here alright, and because Paradox Interactive and community managers for C:S operate from here it might please them too 😀 )
  

• Brazil 🇧🇷
  

• France 🇫🇷
  
  

• Indonesia 🇮🇩
  

• South Korea 🇰🇷 (similar to German but more square font)
  

• Japan
  

New priority and parking signs for existing themes:

• Canada
  

• Germany
  

• UK
  

• USA
  

[originalfoo]

These look great!

I think the only other notable one would be Japan which has blue text on the speed limit signs.

[originalfoo]

The icons are embedded in the .dll file? If so, they're all still getting loaded in to RAM along with the .dll?

[kvakvs]

The icons are embedded in the .dll file? If so, they're all still getting loaded in to RAM along with the .dll?

Yes I did not change the way textures are delivered into the resulting DLL, they are embedded but as compressed PNG, that's about 20kb per file. They are loaded on demand though.

[kvakvs]

Plus something tells me Windows loads DLL files using mmap. Should doublecheck if actual real memory is used.
https://stackoverflow.com/questions/43548270/are-embedded-resources-in-a-net-assembly-loaded-from-disk-or-from-memory-at-run

[krzychu124]

I would be more concern if we instantiate textures -> they will eat VRAM, RAM is not really a problem

The icons are embedded in the .dll file? If so, they're all still getting loaded in to RAM along with the .dll?

Textures created from those images are worse, since they eat VRAM which you can't really extend without huge performance drop. I think we should compare master with this PR in terms of RAM difference (e.g. in noWorkshop mode), because now we can only guess. TMPE already takes probably somewhere ~200MB when loaded in game (dll of master has +- 6.5MB right now), so 10-15MB more won't make much of a difference.

[originalfoo]

The new speed limits UI only has one set of textures for speed signs and overwrites those textures should user choose different speed sign icon theme (hence lag when switching between themes). At least that's what the code says, I've not tested to see if Unity is doing some weirdness under the hood.

[originalfoo]

EDIT: Apparently SACU no longer exists https://commons.wikimedia.org/wiki/User:Fry1989/Gallery/Road_Signs/SACU

Found another one that might be worthy to add due to it's extremely unusual colour - SACU (South African Customs Union) - SVGs of most of their signs available at link below:

https://commons.wikimedia.org/wiki/Category:SVG_road_signs_in_the_Southern_African_Customs_Union

Could potentially also provide custom Priority sign icons too:

• Yield: https://commons.wikimedia.org/wiki/File:SACU_road_sign_R2.svg
• Stop: https://commons.wikimedia.org/wiki/File:SACU_road_sign_W302.svg

[kvakvs]

South African signs look very much like a mix of German signs and orange Swedish-Finnish style backgrounds. Also the country is not represented in top 15 Steam users, so I assumed also not in top 15 C:S users
https://www.statista.com/statistics/826870/steam-distribution-country/

[originalfoo]

Indonesia NoParking.png sign seems to be the old Parking.png (green parking allowed) sign?

I also noticed that, after changing theme via mod options, the parking overlays won't appear upon tool selection - until I move the camera (probably nothing to do with this PR and only very minor issue tbh).

[kvakvs]

All issues fixed now:

• Indonesian no-parking added a special sign
• Found a bug when parking sign was missing in the current theme, a parking-allowed (green P) was always selected
• Camera cache reset forced when parking tool activates
• Also converted all fonts to curves, to make it easier to do minor edits without installing a dozen of fonts

[originalfoo]

Not for this PR, but would be cool if changing icon theme updated the button icons on tmpe toolbar. (Priority tool shows Yield.png icon, Speed tool shows 30.png, parking tool shows Parking.png)

[originalfoo]

For visual simplicity, would it be worth removing the text box from under the French Yield.png?

It's unreadable in the overlays unless zoomed all the way in, and if we ever wanted to use the icon for the priority signs button on toolbar it would get in the way.

[originalfoo]

LGTM from in-game testing 👍

[krzychu124]

Works great, but...

1. Missing translation keys:
   

2. What about loading previously selected theme - backward compatibility? Not a big deal, but I didn't tested what will happen when loaded savegame with theme different than default (German)

3. Why we are loading textures after loading translations? They are used in game so I'm not sure if is that necessary. I also added log call to Load and Unload methods and I see that we are calling load after translations (that was mentioned) but then again after loading savegame -> there is no Unload call before which suggests small memory leak, but we are changing game Scene between Main Menu to InGame so there is a chance that textured are destroyed similarly to gameobjects without DontDestroyOnLoad call

4. Ok... there is a memory leak -> I don't see the code for unloading textures on mod disable

[kvakvs]

For memory leak my suggestion is to create one or more TextureManager's which will get lifecycle start level loaded event and load, and then will get lifecycle end level unloaded event and unload. In this PR or in separate.

[kvakvs]

What about loading previously selected theme - backward compatibility? Not a big deal, but I didn't tested what will happen when loaded savegame with theme different than default (German)

Theme name is stored in the savegame. When config option contains theme name that is not known, it will reset to default Kmph theme (Kmph_Germany) or to default MPH theme (MPH_UK).

[krzychu124]

For memory leak my suggestion is to create one or more TextureManager's which will get lifecycle start level loaded event and load, and then will get lifecycle end level unloaded event and unload. In this PR or in separate.

It can be done in separate PR, no problem. I'll approve this one, since it works pretty well.

[krzychu124]

👍 memory leak issues can be fixed in the next PR