Speed Limits-cleanup #1275
Merged
Speed Limits-cleanup #1275
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
moved iterators to iterators folder
created LaneUtil
…ods/TMPE into netutil-cleanup1
slow calculations use the Calculate prefix instead of the Get prefix fast access uses the Get prefix.
kianzarrin
added
code cleanup
originalfoo
approved these changes
Jan 5, 2022
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Scope: In this PR I have done nothing more than to rename some methods inside Speed Limit Manager. This PR is a precursor to #1266.
Objective: the naming of the methods are confusing. And we don't need 2 methods, one for fast access and one for slow access!
Changes:
I now use the following naming standard:
GetPrefixCalculatePrefixAlso There is no need to expose Calculate in the API so I replaced it with a simple Get Method.
Compatibility:
The only place where Speed Limit Manager is used externally is in Adaptive Networks and this PR does not break AN compatibility.