Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Slm data rework hotfix #1285

Merged
merged 2 commits into from
Jan 17, 2022
Merged

Slm data rework hotfix #1285

merged 2 commits into from
Jan 17, 2022

Conversation

krzychu124
Copy link
Member

Note it's a hotfix for #1277

  • fixed issue with incorrectly calculated averaged speed limit in Segments mode by reverting changes and adopting to renamed methods - issue affected only calculations for displaying overlay signs in Segments mode,
  • improvement: forced Segments mode for non-interactive Speed Limits overlay (overlays tab), shortcut still works

@krzychu124 krzychu124 added the SPEED LIMITS Feature: Speed limits label Jan 16, 2022
@krzychu124 krzychu124 added this to the 11.6.0 milestone Jan 16, 2022
@krzychu124 krzychu124 self-assigned this Jan 16, 2022
@krzychu124 krzychu124 mentioned this pull request Jan 16, 2022
7 tasks
@kianzarrin
Copy link
Collaborator

silly me. I tried to simplify the code and broke it!
Thanks for the fix.

@kianzarrin
Copy link
Collaborator

@krzychu124 the other review has 2+ approvals already. how many approvals will this one need?

@krzychu124
Copy link
Member Author

You can merge it 😉

@kianzarrin kianzarrin merged commit 89286e1 into SLM-data-rework Jan 17, 2022
kianzarrin added a commit that referenced this pull request Jan 18, 2022
* Calculate IsCustomisable on the go
* change lane-wise speed limit cache to be simpler and faster.
* don't store vanilla speed limits on NetInfo.
* improved usage of  GetDefaultSpeedLimit

* Slm data rework hotfix (#1285) (Krzysztof )
* Fix regards to incorrectly calculated average speed for overlay in segment mode
* Improvement: show Segment mode (with shortcuts) in a non-interactive SpeedLimits gui overlay
@originalfoo originalfoo modified the milestones: 11.6.0, 11.6.3 Jan 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
SPEED LIMITS Feature: Speed limits
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants