Refactor OptionsManager.cs #1321
Conversation
- Code provided by kvakvs
originalfoo
added
the
code cleanup
|
Heh, I've not checked through it all yet - just copied & pasted from your repo. It's compiling though and seems to work on cursory glance in-game. |
- also manually checked all options are working
|
I've checked through each option via visual inspection, then tested each of them in game, which is something I never want to do again lol. EDIT: The fact that turning option on often enables one or more other options (eg. enabling mod features) was an absolute freaking nightmare in respect to testing what was happening. |
|
Ok to put this in to 11.6.4.3 release? |
|
I didn't test it but also didn't spot any bug (analyzed changes carefully by counting indexes on my fingers) 😄 |
|
yeha, trust me, you don't want to try testing every option with the way the options screen currently works (especially Policies tab) I thought my brain was going to burst lol |
| save[31] = (byte)(Options.parkingRestrictionsOverlay ? 1 : 0); | ||
| save[32] = (byte)(Options.banRegularTrafficOnBusLanes ? 1 : 0); | ||
| save[33] = (byte)(Options.showPathFindStats ? 1 : 0); | ||
| save[34] = Options.altLaneSelectionRatio; |
There was a problem hiding this comment.
Loads DLSPercentage, and stores altLaneSelectionRatio, hope they are the same variable
TMPE.zip
Refactors
OptionsManager.csto use specific index references, resulting in cleaner and more maintainable code.This is a prerequisite for following PRs: