Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show full What's New version in UI #1335

Merged
merged 2 commits into from
Jan 29, 2022
Merged

Conversation

originalfoo
Copy link
Member

This PR changes the version that's shown in-game; instead of the assembly version, it uses the version from WhatsNew.cs which has a manually specified build number.

In mod options:

image

In game toolbar:

image

Log file:

Info 0.0539720: TM:PE 11.6.4.2 STABLE - Build 11.6.4.33864 STABLE compiled under C:SL 1.14.0-f4

@originalfoo originalfoo added the enhancement Improve existing feature label Jan 29, 2022
@originalfoo originalfoo added this to the 11.6.4-hotfix-3 milestone Jan 29, 2022
@originalfoo originalfoo self-assigned this Jan 29, 2022
Copy link
Collaborator

@kvakvs kvakvs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So now Whatsnew.version becomes the primary version, and its typed in manually instead of assembly version?
Versionutil.VersionString might need a comment about this?

@originalfoo
Copy link
Member Author

Well, we need both IMO - the build number in shared assembly info version will change with every build which might still be useful.

For now I just wanted a simple change that's not going to break anything such as other mods - it's only the display string that's changed and anything already reading that already has to parse the version number from the string.

A more nuanced update can come as part of work on #1276 / #685

@originalfoo
Copy link
Member Author

BTW, the main reason I want this basic change is so that users can check if they've got latest mod ver via UI - there's lots of issues recently with Steam not downloading mod updates.

Currently there's no easy way to check visually in-game (11.6.4.2 , 11.6.4.1 and 11.6.4.0 are all shown as 11.6.4). We can find out from logs, but even there it's not trivial as we'd have to compare the build number against releases.

@originalfoo originalfoo merged commit 9373a4d into master Jan 29, 2022
@originalfoo originalfoo deleted the use-whats_new-version-in-ui branch January 29, 2022 21:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improve existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants