Aircraft pathfinding fix

[krzychu124]

TM:PE is searching for path for all AI's in game, so added vehicleType converter to handle all explicitly used vehicles by pathfinding. Previously they set vehicle type None which caused issues in path-finding code testing lanes with allowed vehicle types. This change may fix other rare issues that happened in the past for AIs not explicitly managed by TM:PE

closes #1327
closes #1329

Build zip

[originalfoo]

Should we add a pathfinder version number (similar to how we add version in WhatsNew.cs) and if user loads a city with earlier (or no) pathfinder version clear all traffic to ensure all vehicles are using updated paths? #485

[krzychu124]

@aubergine10 no need here, I think. This applies only to aircrafts taking off so it will start working for new paths. Clearing all vehicles is a bit overkill in this case. Would be cool to add section in the options where user could select which vehicles are cleared.

[originalfoo]

... Clearing all vehicles is a bit overkill in this case. Would be cool to add section in the options where user could select which vehicles are cleared.

Would it be worth exposing ExtVehicleManager.DetermineVehicleTypeFromAIType() as public to make that easier? That way we can generate checkboxen from ExtVehicleType enum, also have a method that accepts an ExtVehicleType and despawns matching vehicles?

EDIT: #1341

[originalfoo]

Tested this in-game, although without an airport... so I was focussed on all the other vehicles which seem to be working fine :)

• Public transport incl. trains, buses, ferries
• Cargo - trains, ships
• Emergency helicopters
• City services and road-based emergency services
• Cars, etc.

[originalfoo]

Done another in-game test with a small airport and it seems to be working as advertised.

[originalfoo]

@krzychu124 If you can add a pathfinder version check, and want to despawn planes with this new update (assuming #1341 gets merged first):

Singleton<SimulationManager>.instance.AddAction(() => {
    UtilityManager.Instance.DespawnVehicles(ExtVehicleType.Plane);
});

[krzychu124]

@krzychu124 If you can add a pathfinder version check, and want to despawn planes with this new update (assuming #1341 gets merged first):

Singleton<SimulationManager>.instance.AddAction(() => {
    UtilityManager.Instance.DespawnVehicles(ExtVehicleType.Plane);
});

I'll implement suggestion from kvakvs and merge, then you can add such thing in your PR 😉

[originalfoo]

Will prolly do separate PR for that once both #1341 and #1338 are merged.