Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CSUR: Lane connectors on transition segments not available #1357

Merged
merged 2 commits into from
Feb 5, 2022
Merged

CSUR: Lane connectors on transition segments not available #1357

merged 2 commits into from
Feb 5, 2022

Conversation

krzychu124
Copy link
Member

@krzychu124 krzychu124 commented Feb 5, 2022 •
edited by originalfoo

  • divide by zero (segment m_averageLength) leads to invisible lane connectors

Closes #1355

TMPE.zip

@krzychu124 krzychu124 added BUG Defect detected confirmed Represents confirmed issue or bug LANE ROUTING Feature: Lane arrows / connectors labels Feb 5, 2022
@krzychu124 krzychu124 self-assigned this Feb 5, 2022
@originalfoo originalfoo added this to the 11.6.4-hotfix-6 milestone Feb 5, 2022
originalfoo added a commit that referenced this pull request Feb 5, 2022
@originalfoo
What's New in TM:PE 11.6.4.6?
8470579 
This is a bugfix release which resolves some lane connector bugs relating to CSUR and similar networks:

- [Meta] TM:PE 11.6.4-hotfix-6
- [Meta] Fixes some issues relating to CSUR and similar networks
- [Fixed] Missing lane connectors on CSUR and similar networks #1355 #1357 (krzychu124)
@originalfoo originalfoo mentioned this pull request Feb 5, 2022
Merged
originalfoo
originalfoo approved these changes Feb 5, 2022
View reviewed changes
Copy link
Member

@originalfoo originalfoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Note: Not tested in game as I don't have any CSUR roads, but code makes sense.

@originalfoo originalfoo added COMPATIBILITY Mod (in)compatibility / checker EXTERNAL Mod conflict or other external factor labels Feb 5, 2022
@krzychu124 krzychu124 merged commit 6c1d706 into master Feb 5, 2022
@krzychu124 krzychu124 deleted the bugfix/1355-csur-lane-connector-issue branch February 5, 2022 19:38
@originalfoo originalfoo mentioned this pull request Feb 15, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kvakvs kvakvs kvakvs approved these changes

@originalfoo originalfoo originalfoo approved these changes

@DaEgi01 DaEgi01 Awaiting requested review from DaEgi01

@chameleon-tbn chameleon-tbn Awaiting requested review from chameleon-tbn

Assignees

@krzychu124 krzychu124

Labels
BUG Defect detected COMPATIBILITY Mod (in)compatibility / checker confirmed Represents confirmed issue or bug EXTERNAL Mod conflict or other external factor LANE ROUTING Feature: Lane arrows / connectors
Projects
None yet
Milestone
11.6.4-hotfix-6
Development

Successfully merging this pull request may close these issues.

CSUR Lane connector - missing connectors
3 participants
@krzychu124 @kvakvs @originalfoo