Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename OptionsGameplayTab -> GameplayTab #1370

Merged
merged 3 commits into from
Feb 13, 2022
Merged

Conversation

originalfoo
Copy link
Member

Phase 1 refactor as per #1356

There will be separate PR for each of the other tabs.

Phase 1 refactor as per #1356

There will be separate PR for each of the other tabs.
@originalfoo originalfoo added the code cleanup Refactor code, remove old code, improve maintainability label Feb 6, 2022
@originalfoo originalfoo added this to the 11.6.5 milestone Feb 6, 2022
@originalfoo originalfoo self-assigned this Feb 6, 2022
Copy link
Collaborator

@kvakvs kvakvs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The big question for a separate PR: Why do option tabs OWN the options. They shouldn't.

@originalfoo originalfoo added the Settings Road config, mod options, config xml label Feb 7, 2022
@originalfoo originalfoo merged commit b464f5a into master Feb 13, 2022
@originalfoo originalfoo deleted the rename-OptionsGameplayTab branch February 13, 2022 01:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code cleanup Refactor code, remove old code, improve maintainability Settings Road config, mod options, config xml
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants