Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

What's new - StackoverflowException fix attempt #1393

Merged
merged 5 commits into from
Feb 13, 2022

Conversation

krzychu124
Copy link
Member

@krzychu124 krzychu124 commented Feb 13, 2022

Reduced autolayout use where possible

Hopefully closes #1314
Compiled Zip

In debug mode (mono) opening window caused full recalculation of UI, probably also visible in release - notice main menu buttons text for a split second

2022-02-13.01-52-11.mp4

With changes in this PR that issue seem to be solved (tried with full changelog list too) - maybe it's just me but it feels like it opens much faster/with less delay between click and show.

2022-02-13.01-53-45.mp4

@krzychu124 krzychu124 added STABLE TM:PE STABLE branch UI User interface updates TEST TEST version of the mod / workshop page labels Feb 13, 2022
@krzychu124 krzychu124 self-assigned this Feb 13, 2022
TLM/TLM/UI/WhatsNew/WhatsNewPanel.cs Outdated Show resolved Hide resolved
@originalfoo originalfoo added this to the 11.6.5 milestone Feb 13, 2022
Copy link
Member

@originalfoo originalfoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Built from source & tested from main menu / in-game.

LGTM 👍

@krzychu124
Copy link
Member Author

Ok, I've got report from the user affected with crash on click - he said it works now 🥳

Copy link
Contributor

@chameleon-tbn chameleon-tbn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What Else to say... Lgtm

@krzychu124 krzychu124 merged commit 9dada87 into master Feb 13, 2022
@krzychu124 krzychu124 deleted the bugfix/1314-stackoverflow-whats-new branch February 13, 2022 20:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
STABLE TM:PE STABLE branch TEST TEST version of the mod / workshop page UI User interface updates
Projects
None yet
Development

Successfully merging this pull request may close these issues.

StackOverflowException - WhatsNewPanel.cs
3 participants