Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Converted almost all m_lanes.m_buffer[laneId] calls to laneId.ToLane() #1396

Merged
merged 1 commit into from
Feb 13, 2022
Merged

Converted almost all m_lanes.m_buffer[laneId] calls to laneId.ToLane() #1396

merged 1 commit into from
Feb 13, 2022

Conversation

DaEgi01
Copy link
Contributor

@DaEgi01 DaEgi01 commented Feb 13, 2022

No description provided.

krzychu124
krzychu124 approved these changes Feb 13, 2022
View reviewed changes
Copy link
Member

@krzychu124 krzychu124 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool, cool, carefully reviewed all changes, didn't notice any bug 👍

originalfoo
originalfoo approved these changes Feb 13, 2022
View reviewed changes
Copy link
Member

@originalfoo originalfoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've not had chance to test in-game, but code looks good and builds with no complaints. 👍

@originalfoo originalfoo added the code cleanup Refactor code, remove old code, improve maintainability label Feb 13, 2022
@originalfoo originalfoo added this to the 11.6.5 milestone Feb 13, 2022
@DaEgi01 DaEgi01 merged commit 8bdced9 into master Feb 13, 2022
@DaEgi01 DaEgi01 deleted the refactoring/ToLane branch February 13, 2022 19:46
@originalfoo originalfoo mentioned this pull request Feb 13, 2022
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@originalfoo originalfoo originalfoo approved these changes

@krzychu124 krzychu124 krzychu124 approved these changes

@kvakvs kvakvs Awaiting requested review from kvakvs

@kianzarrin kianzarrin Awaiting requested review from kianzarrin

Assignees

@DaEgi01 DaEgi01

Labels
code cleanup Refactor code, remove old code, improve maintainability
Projects
None yet
Milestone
11.6.5.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@DaEgi01 @originalfoo @krzychu124