Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ToCitizenUnit via extension methods. #1399

Merged
merged 2 commits into from
Feb 13, 2022
Merged

Conversation

DaEgi01
Copy link
Contributor

@DaEgi01 DaEgi01 commented Feb 13, 2022

Created a ToCitizenUnit extension method.
Converted all Singleton.instance.m_units.m_buffer[citizenUnitId] calls to citizenUnitId.ToCitizenUnit().

Converted all Singleton<CitizenManager>.instance.m_units.m_buffer[citizenUnitId] calls to citizenUnitId.ToCitizenUnit().
Copy link
Member

@originalfoo originalfoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@originalfoo originalfoo added the code cleanup Refactor code, remove old code, improve maintainability label Feb 13, 2022
@originalfoo originalfoo added this to the 11.6.5 milestone Feb 13, 2022
@DaEgi01 DaEgi01 merged commit 27fe199 into master Feb 13, 2022
@DaEgi01 DaEgi01 deleted the refactoring/CitizenUnit branch February 13, 2022 21:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code cleanup Refactor code, remove old code, improve maintainability
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants