Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Converted all calls from Singleton<VehicleManager>.instance.m_vehicle… #1413

Merged
merged 3 commits into from
Feb 16, 2022

Conversation

DaEgi01
Copy link
Contributor

@DaEgi01 DaEgi01 commented Feb 16, 2022

…s.m_buffer to ToVehicle extension method instead.

Created additional extension methods for convenience.
Deleted some commented out code that contains m_vehicles related stuff.

…s.m_buffer to ToVehicle extension method instead.

Created additional extension methods for convenience.
Deleted some commented out code that contains m_vehicles related stuff.
@DaEgi01 DaEgi01 added the code cleanup Refactor code, remove old code, improve maintainability label Feb 16, 2022
Copy link
Collaborator

@kvakvs kvakvs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

Copy link
Member

@originalfoo originalfoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Compiled as DEBUG and RELEASE, not tested in-game.

Code LGTM 👍

@originalfoo originalfoo added this to the 11.6.5.0 milestone Feb 16, 2022
@krzychu124 krzychu124 merged commit e5ae3ed into master Feb 16, 2022
@originalfoo originalfoo deleted the refactoring/ToVehicle branch February 16, 2022 19:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code cleanup Refactor code, remove old code, improve maintainability
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants