Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split some options in to GameplayTab_VehicleBehaviourGroup #1416

Merged
merged 12 commits into from
Feb 21, 2022

Conversation

originalfoo
Copy link
Member

@originalfoo originalfoo commented Feb 16, 2022

Part of #1356 Phase 2.

  • Vehicle behaviour group moved in to own class
  • Updated references from call sites
  • Deleted several now-obsolete Set... functions
  • Removed most change handlers as CheckboxOption automates that stuff

Will need testing in-game. Log file contains extended trace for checkbox options.

Compiled mod for testing: TMPE.zip

@originalfoo originalfoo added code cleanup Refactor code, remove old code, improve maintainability DO NOT MERGE YET Don't merge this PR, even if approved, until further notice Settings Road config, mod options, config xml labels Feb 16, 2022
@originalfoo originalfoo added this to the 11.6.5.1 milestone Feb 16, 2022
@originalfoo originalfoo self-assigned this Feb 16, 2022
originalfoo added a commit that referenced this pull request Feb 16, 2022
Allows custom validator to intercept value change and determine what to do.
@originalfoo originalfoo marked this pull request as draft February 16, 2022 22:36
@originalfoo originalfoo added the Dependent This issue is blocked by another issue. label Feb 18, 2022
@originalfoo originalfoo marked this pull request as ready for review February 21, 2022 01:09
@originalfoo
Copy link
Member Author

ready for review

@originalfoo originalfoo removed the Dependent This issue is blocked by another issue. label Feb 21, 2022
@originalfoo originalfoo removed the DO NOT MERGE YET Don't merge this PR, even if approved, until further notice label Feb 21, 2022
@originalfoo originalfoo merged commit dfd16b7 into master Feb 21, 2022
@originalfoo originalfoo deleted the refactor-gameplay-vehicle-behaviour-group branch February 21, 2022 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code cleanup Refactor code, remove old code, improve maintainability Settings Road config, mod options, config xml
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants