Add button classes for use in mod options #1424
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- `ActionButton` triggers handler on click - `UrlButton` opens a url on click - `OptionButtonBase` is base for both buttons - `OpenUrlsInSteamOverlay` - new global option - ...configurable via General tab option
originalfoo
added
docs
originalfoo
added a commit
that referenced
this pull request
Feb 19, 2022
|
@krzychu124 any feedback on this? |
krzychu124
requested changes
Feb 20, 2022
originalfoo
added a commit
that referenced
this pull request
Feb 20, 2022
Based on feedback from another PR: #1424 (review)
Merged
krzychu124
approved these changes
Feb 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of ongoing work for #1356
ActionButtontriggers handler on clickUrlButtonopens a url on clickOptionButtonBaseis base for both buttonsOpenUrlsInSteamOverlay- newMainglobal option (also bumped global config version)In preparation for: #813, #733, #659, etc.
Later, once all mod options are using helper components, I plan on updating options screen to be able to 'refresh' when language is changed (rather than forcing C:SL to rebuild entire mod options library).