Read elevation keybind from vanilla settings #1454
Conversation
…e keybinds page and OSD where used, Added dynamic tag replacement function
krzychu124
added
Usability
krzychu124
requested review from
originalfoo,
DaEgi01,
kianzarrin and
chameleon-tbn
|
I've done some brief testing in-game and it seems to work as advertised. Will do some more testing tomorrow. |
|
can't we just use the CS's keybind for this? |
It does exactly that... Previously it was hardcoded to PageUp/PageDown |
|
No I mean instead of adding an entry to TMPE options we can just use |
|
Have you read the code? It's just read-only thing, not saved anywhere. |
The keybinds tab in TMPE options doubles-up as a quick reference guide for users, hence listing the elevation keybinds. |
| /// <param name="e"></param> | ||
| /// <returns>true once when user releases the key.</returns> | ||
| public bool KeyUp() { | ||
| return Key.IsKeyUp(); |
There was a problem hiding this comment.
I should have done the same thing for the KeyDown() method above
There was a problem hiding this comment.
Hmm, KeyDown() method above is weird, I tried to use it and after rebinding PageUp to something else like [ or comma (theoretically not used anywhere) it stopped working, I couldn't figure out why KeyDown() always return false - I even attached debugger 😂
krzychu124
deleted the
feature/1326-read-elevation-keybind-from-vanilla-settings
branch
|
Oops - just noticed an issue with this PR:
Only one of those shortcuts will go to underground view, but both are listed as switching to undergound? Maybe it should be context sensitive (using Edit: Alternatively the hint text could be |
|
It's a translation on the Crowdin, needs the update 😉 |
|
I'll add to the locale updates list :) |
Closes #1326
Keybindstab[[xyz]]tag with replacement values (each match gets own replacement value) - skip {x} matches could be added in the future if necessary for complex translations text,Changes in action:
2022-03-04.01-18-03.mp4