Modernise several uses of GetSortedLanes()
#1490
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
originalfoo
added
the
code cleanup
originalfoo
commented
Mar 24, 2022
kianzarrin
reviewed
Mar 25, 2022
kianzarrin
approved these changes
Mar 25, 2022
|
code looks good. |
krzychu124
requested changes
Mar 27, 2022
| laneTypeFilter: SpeedLimitManager.LANE_TYPES, | ||
| vehicleTypeFilter: SpeedLimitManager.VEHICLE_TYPES, | ||
| sort: false).Count; | ||
| int count0 = segmentId0.ToSegment().GetSortedLanes( |
There was a problem hiding this comment.
I wasn't sure what to do here because we can't store ref in an enumerable.
There was a problem hiding this comment.
Oh, ok true, I didn't check in the IDE, ignore
Co-authored-by: Krzysztof <krzychu124@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Got tired of seeing the
obsoletewarnings on big chunks ofextSegmentManager.GetSortedLanes()so started porting some over to the newer NetSegment extension.I'm doing these by hand as there seems to be lots of little fringe issues in code where GetSortedLanes() is used - for example, sometimes we don't need the lanes sorting (eg. if we're just counting the number of returned lanes).