hollow floating wire

[kianzarrin]

fixes #1485 : make it easy to distinguish between adding/removing connection

Visual changes :

• floating wire is white and hollow.

• when connection is made the underneath connection is visible.

• +/- cursors help to distinguish adding/removing lane connection

• cursor code:

  • Added CursorUtil to create/release cursors
  • Added OverrideCursor to subtools.
  • OverrideCursor also handles the nope_cursor (code moved to lane connection tool).

TMPE.zip

[kianzarrin]

[kvakvs]

Minus cursor looks very similar to ⛔ road sign, maybe change color to darker red or black
But this is nice

[chameleon-tbn]

maybe this?

[originalfoo]

what about TMPE logo blue background for the - icon?

[kianzarrin]

which TMPE logo?

[originalfoo]

which TMPE logo?

the mod logo from workshop page; the darker blue with white - sign might work:

[krzychu124]

Why without a pointer? Also... now when I think of it, why not without circle, just pointer + sign ➕(green), ➖(dark blue)?

[kianzarrin]

@chameleon-tbn Can you please address the sprite ideas?

[kianzarrin]

meanwhile cham plays with sprites can we do the rest of the code review?

[originalfoo]

👍

[kianzarrin]

thanks. should I wait for cham to come up with better icon or should I just merge and come up with sprite later?
merging will unblock future progress and reduce chance of conflict.

[originalfoo]

I think merge and we can start testing stuff and come up with better icon later if desired. I'm really liking the way this is working already in this PR.

[chameleon-tbn]

Why without a pointer? Also... now when I think of it, why not without circle, just pointer + sign ➕(green), ➖(dark blue)?

What's the need of a pointer there? why not center the + / - into the connector circle? ... would clearly show what it does...

@chameleon-tbn Can you please address the sprite ideas?

anything else?

[kvakvs]

"Pointer" + "something to the current edit mode" is a good idea, i like

[kianzarrin]

Ill create a issue for such improvements

[krzychu124]

Why without a pointer? Also... now when I think of it, why not without circle, just pointer + sign ➕(green), ➖(dark blue)?

What's the need of a pointer there? why not center the + / - into the connector circle? ... would clearly show what it does...

@chameleon-tbn Can you please address the sprite ideas?

anything else?

Because we already use "pointer" + "thing" to do initial selection? It's just to make UX more or less consistent, also similar to how game handles user interactions where it shows cursor

[kianzarrin]

#1498