Destroy UI texture immediately to solve race condition #1516
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
krzychu124
added
confirmed
originalfoo
reviewed
Apr 4, 2022
chameleon-tbn
approved these changes
Apr 5, 2022
originalfoo
approved these changes
Apr 5, 2022
This was referenced Apr 5, 2022
|
merge? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1514
It turned out that destroying of
MainWindowis delayed - it destroys also the UI texture atlas because it is not needed anymore.When new window is created within the same frame it finds the atlas texture that will be destroyed at the end of frame (so it will be
nullafter a moment). The first render of new component (in the next frame) check if its atlas isnot null- otherwise takes default atlas.I added also a simple
ifcondition to rebuild textures with translation only if really needed (language changed).Build zip