Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modernise remaining uses of GetSortedLanes() #1521

Merged
merged 6 commits into from
Apr 8, 2022

Conversation

originalfoo
Copy link
Member

Final batch of GetSortedLanes() updates.

Also reduced memalloc/gc of lists in some Record classes, and removed some unused using statements.

Final batch of `GetSortedLanes()` updates.

Also reduced memalloc/gc of lists in `Record` classes.
@originalfoo originalfoo added the code cleanup Refactor code, remove old code, improve maintainability label Apr 6, 2022
@originalfoo originalfoo added this to the 11.6.5.2 milestone Apr 6, 2022
@originalfoo originalfoo self-assigned this Apr 6, 2022
@originalfoo
Copy link
Member Author

@kianzarrin how often do the record lists get created? I assume it's only in asset editor and only when plopping assets on map so not performance critical?

@kianzarrin
Copy link
Collaborator

Not performance critical. It happens due to a user event:

  • asset editor save
  • move it copy/save
  • TMPE priority road button pressed (so that I can undo)
  • in future: every time user changes TMPE rules (so that I can undo)

@originalfoo
Copy link
Member Author

bump

@originalfoo originalfoo merged commit f3925bf into master Apr 8, 2022
@originalfoo originalfoo deleted the sorted-lanes-modernisation3 branch April 8, 2022 21:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code cleanup Refactor code, remove old code, improve maintainability
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants