-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
routing detector tool #1534
routing detector tool #1534
Conversation
address warnings
+/- cursors subtool can override cursor
EDIT: Debug only - I suggest just re-use existing icons for button, rather than adding new ones, to avoid further filesize bloat of the mod. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
I'd remove TLM/TLM/UI/MainMenu/MainMenuPanel.cs before merge.
As mentioned in previous comment, if it's debug only tool consider finding some existing texture to use for the button rather than adding new textures.
@aubergine10
That is what I did. it was an empty file so I just deleted it :). that is why it is showing here.
But then how can you tell the difference between different tools? these icons are not too big. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Select node, hover above an outgoing lane (any without white circle): NullReferenceException: Object reference not set to an instance of an object
at TrafficManager.UI.SubTools.RoutingDetector.RoutingDetectorTool.RenderActiveToolOverlay (.CameraInfo cameraInfo) [0x00000] in <filename unknown>:0
at TrafficManager.UI.TrafficManagerTool.RenderOverlayImpl (.CameraInfo cameraInfo) [0x00000] in <filename unknown>:0
UnityEngine.DebugLogHandler:Internal_LogException(Exception, Object)
UnityEngine.DebugLogHandler:LogException(Exception, Object)
UnityEngine.Logger:LogException(Exception, Object)
UnityEngine.Debug:LogException(Exception)
TrafficManager.Util.Shortcuts:LogException(Exception, Boolean)
TrafficManager.UI.TrafficManagerTool:RenderOverlayImpl(CameraInfo)
TrafficManager.UI.TrafficManagerTool:RenderOverlay(CameraInfo)
ToolManager:EndOverlayImpl(CameraInfo)
SimulationManagerBase`2:EndOverlay(CameraInfo)
ToolManager:IRenderableManager.EndOverlay(CameraInfo)
RenderManager:Managers_RenderOverlay(CameraInfo)
OverlayEffect:OnPostRender() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A little bit over engineered (you don't need anything more than just the lane end (laneID + nodeID) to get all its transitions) but whatever.
It does what was advertised.
0a1c54d
to
f5cefba
Compare
it shows different lane transitions type with different colors. when you hover over target lane it shows list of all transitions to that lane.
TODO:
Future:
TMPE.zip