lighweight highway merging rules

[kianzarrin]

fixes #1530 . see issue for details.

ATTENTION: Only applies to highway on-ramps(merging) where lane arithmetic works (incoming= outgoing).

bonus: I also modified optimized the way global options variables are accessed. to speed up value access I cache the delegate. this reduces one if condition to check null.

latest branch build: TMPE.zip

tests:

• routing: cars will stay in lane when condition is met. this can be tested using routing detector tool.
• edit option: changing option takes effect immediately.
• no more than one highway rules policy: enabling legacy highway rules or the new highway merging rules disables the other. it should be possible to turn both off.
• option persistency: highway rule option should persist when saving/loading game
• routing persistency: when saving with this option, existing highways will keep their routing after load.
• main menu: it should not be possible to change this option in main menu.

test condition: according to #1530.

• only works on highways. Does not work on urbran/transition nodes.
• only works when merging
• only works when lane mathematics add up (ie incoming lanes == outgoing lanes).
• only works when there is no lane connections on the merging lanes. (same as legacy)
• there is no cars may switch lanes on junctions rule. (same as legacy)
• does not restrict lane arrow tool.

backward compatibility:

• legacy highway rules still works
• legacy routing persistency
• legacy option takes effect immediately.

[krzychu124]

Werid behavior:

• initial state: both options disabled
• enabling highway rules (old) and then enabling highway rules (new) disables both and also calls OptionsManager.UpdateRoutingManager() 3 times.

[krzychu124]

@kianzarrin did you test this? After reading the code I doubt it does anything when "new highway rules" is enabled and may apply changes to non-highway roads too if somehow works.

[kianzarrin]

@krzychu124 its draft. did you read description?

[krzychu124]

It wasn't a draft when I was reviewing and testing the code...

[kianzarrin]

I did not ask for review on this on the description said this is not ready.

[kianzarrin]

@krzychu124 did you test this? After reading the code I doubt it does anything when "new highway rules" is enabled and may apply changes to non-highway roads too if somehow works.
I don't understand why you say that.
Except for a typo the code is otherwise fine:

and does not apply to non-highway either.

[krzychu124]

Hmm, so it's no longer restricted to one-way roads like legacy (line 552-553 below)?

[kianzarrin]

That is actually a very interesting point. What should we do in case of 2 way highways like the highway over wall collection?

[kianzarrin]

practically numOutgoingSegments == 1 && numIncomingSegents == 2 only works for oneway (unless if you really try to break it but even then lane arithmetic won't add up).

I will add condition for oneway to clarify/full-proof the code.

[kianzarrin]

BTW I just noticed when using legacy highway rule option one lane may not be not used at all

[kianzarrin]

OK now I only check for oneway highways.

[kianzarrin]

I created #1561

[kvakvs]

Amazing feature
Is there any easy way to graphically render incoming and outgoing lanes as a single curve? There should be a way, like build a bezier from center of incoming to center of outgoing using node as a bezier pivot. Or even from last 75% of incoming to first 25% of outgoing.

[kianzarrin]

@aubergine10 @krzychu124 I hope you didn't forget about this. I have addressed the issues you raised.

[kianzarrin]

@aubergine10 have your concerns been addressed?

[originalfoo]

@kianzarrin I'll be testing this later today.

[kianzarrin]

@aubergine10 can I merge this? (you have requested changes).

no response.