Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix broken hovered element detection after hovering invalid element #1594

Merged
merged 3 commits into from
Jun 9, 2022
Merged

Fix broken hovered element detection after hovering invalid element #1594

merged 3 commits into from
Jun 9, 2022

Conversation

krzychu124
Copy link
Member

@krzychu124 krzychu124 commented Jun 7, 2022 •
edited

Steps to reproduce:

  • activate Lane connector tool,
  • hover underground node in normal mode,
  • cursor changes to 馃毇 and all interactions are completely blocked for selected tool,
  • require reactivation of tool to temporary fix issue (until cursor will switch to 馃毇 again)

Build ZIP file for tests

@krzychu124 krzychu124 added STABLE TM:PE STABLE branch LANE ROUTING Feature: Lane arrows / connectors regression old bug comes back or a new bug introduced in code that used to work. TEST TEST version of the mod / workshop page labels Jun 7, 2022
@krzychu124 krzychu124 added this to the 11.6.6.0 milestone Jun 7, 2022
@krzychu124 krzychu124 self-assigned this Jun 7, 2022
kianzarrin
kianzarrin approved these changes Jun 7, 2022
View reviewed changes
Copy link
Collaborator

@kianzarrin kianzarrin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code looks good and passes test.

chameleon-tbn
chameleon-tbn approved these changes Jun 8, 2022
View reviewed changes
Copy link
Contributor

@chameleon-tbn chameleon-tbn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm and works ingame

@krzychu124 krzychu124 merged commit bfeccac into master Jun 9, 2022
@krzychu124 krzychu124 deleted the bugfix/1491-regression-cursor-hover branch June 9, 2022 17:17
@krzychu124 krzychu124 mentioned this pull request Jul 21, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kianzarrin kianzarrin kianzarrin approved these changes

@chameleon-tbn chameleon-tbn chameleon-tbn approved these changes

Assignees

@krzychu124 krzychu124

Labels
LANE ROUTING Feature: Lane arrows / connectors regression old bug comes back or a new bug introduced in code that used to work. STABLE TM:PE STABLE branch TEST TEST version of the mod / workshop page
Projects
None yet
Milestone
11.6.6.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@krzychu124 @kianzarrin @chameleon-tbn